Add support for [Constructor, Custom=Wrap]

Add support for [Constructor, Custom=Wrap]

Adds support for constructors when there's a custom wrap.

This is split off as 2/2 bindings-only change from:
Implement ImageData constructors.
https://codereview.chromium.org/196343032/

Follow-up to:
Use wrapper_configuration consistently in bindings
https://codereview.chromium.org/199633014/

R=haraken
BUG=338804
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169835

[Nils Barth (inactive), 2014-03-24 03:13:18]

Other part of bindings-only change for Sigbjørn's CL.

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:446:
V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(impl.release(),
&{{v8_class}}Constructor::wrapperTypeInfo, wrapper, info.GetIsolate(),
{{wrapper_configuration}});
BTW, the custom wrap() means we don't need to call associateObjectWithWrapper,
right?
(I'm following Sigbjørn's CL.)

[haraken, 2014-03-24 03:32:44]

LGTM

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:446:
V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(impl.release(),
&{{v8_class}}Constructor::wrapperTypeInfo, wrapper, info.GetIsolate(),
{{wrapper_configuration}});
On 2014/03/24 03:13:19, Nils Barth wrote:
> BTW, the custom wrap() means we don't need to call associateObjectWithWrapper,
> right?
> (I'm following Sigbjørn's CL.)

Right. The custom wrap() should be already calling associateObjectWithWrapper.

[Nils Barth (inactive), 2014-03-24 03:33:45]

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:446:
V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(impl.release(),
&{{v8_class}}Constructor::wrapperTypeInfo, wrapper, info.GetIsolate(),
{{wrapper_configuration}});
On 2014/03/24 03:32:44, haraken wrote:
> Right. The custom wrap() should be already calling associateObjectWithWrapper.

Got it; self-explanatory, so no comment needed.

[Nils Barth (inactive), 2014-03-24 06:58:36]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-24 06:58:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/206793006/1

[commit-bot: I haz the power, 2014-03-24 07:59:08]

Change committed as 169835

[sof, 2014-03-24 08:06:43]

https://codereview.chromium.org/206793006/diff/1/Source/bindings/tests/result...
File Source/bindings/tests/results/V8TestInterfacePython2.cpp (right):

https://codereview.chromium.org/206793006/diff/1/Source/bindings/tests/result...
Source/bindings/tests/results/V8TestInterfacePython2.cpp:85:
V8DOMWrapper::associateObjectWithWrapper<V8TestInterfacePython2>(impl.release(),
&V8TestInterfacePython2::wrapperTypeInfo, wrapper, info.GetIsolate(),
WrapperConfiguration::Dependent);
Shouldn't this be calling wrap()?

[sof, 2014-03-24 08:16:09]

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:442: {% if has_custom_wrap %}
This isn't complete; the constructor overloads need to arrange for wrap() to be
called (which is what the original CL did.)

[Nils Barth (inactive), 2014-03-24 08:49:10]

I don't follow the issue;
I just factored out the v8SetReturnValue call.

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/206793006/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:442: {% if has_custom_wrap %}
On 2014/03/24 08:16:10, sof wrote:
> This isn't complete; the constructor overloads need to arrange for wrap() to
be
> called (which is what the original CL did.)

I don't follow;
I rearranged the original CL slightly so the wrap() call is used
to initialize wrapper,
separately from the v8SetReturnValue call.

[Nils Barth (inactive), 2014-03-24 08:55:27]

https://codereview.chromium.org/206793006/diff/1/Source/bindings/tests/result...
File Source/bindings/tests/results/V8TestInterfacePython2.cpp (right):

https://codereview.chromium.org/206793006/diff/1/Source/bindings/tests/result...
Source/bindings/tests/results/V8TestInterfacePython2.cpp:85:
V8DOMWrapper::associateObjectWithWrapper<V8TestInterfacePython2>(impl.release(),
&V8TestInterfacePython2::wrapperTypeInfo, wrapper, info.GetIsolate(),
WrapperConfiguration::Dependent);
On 2014/03/24 08:06:43, sof wrote:
> Shouldn't this be calling wrap()?

Oh, good catch!
(Accidentally did for *named* constructors.)