third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp - Issue 2067853002: Upgrade custom elements when inserting a node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

Issue 2067853002: Upgrade custom elements when inserting a node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor editorial Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

index 8da5f43b04b0a562c632977f40902cca1a9dd23c..c807dd30ef8916588ce6bd73dcfaf99bb92f0866 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

@@ -16,7 +16,10 @@ CustomElementUpgradeReaction::CustomElementUpgradeReaction(

void CustomElementUpgradeReaction::invoke(Element* element)

{

- m_definition->upgrade(element);

+ // Multiple upgrade reactions could be enqueued because the state changes in

dominicc (has gone to gerrit) 2016/06/16 05:26:41 This has a step number in the spec; maybe referenc

+ // upgrade(). Don't call upgrade() in such cases.

+ if (element->getCustomElementState() == CustomElementState::Undefined)

+ m_definition->upgrade(element);

}

} // namespace blink