third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp - Issue 2067853002: Upgrade custom elements when inserting a node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

Issue 2067853002: Upgrade custom elements when inserting a node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor editorial Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElement.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

index bf8acd6fe36eabce44f76102a7394b91cb2ee86e..3c950fd707b4ea66a9a89f7ea875688a1f562fc8 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

@@ -102,6 +102,8 @@ HTMLElement* CustomElementDefinition::createElementAsync(Document& document, con

// https://html.spec.whatwg.org/multipage/scripting.html#concept-upgrade-an-element

void CustomElementDefinition::upgrade(Element* element)

{

+ DCHECK_EQ(element->getCustomElementState(), CustomElementState::Undefined);

if (!m_observedAttributes.isEmpty())

enqueueAttributeChangedCallbackForAllAttributes(element);