Upgrade custom elements when inserting a node

Upgrade custom elements when inserting a node

This patch tries to upgrade[1] custom elements when inserting a node[2].

With this change, setting to innerHTML/outerHTML enqueues upgrade
reactions if the definition is not null, but then
Element::insertedInto() enqueues upgrade reactions again. Added the
guard in CustomElementDefinition::upgrade() for such cases.

[1] https://html.spec.whatwg.org/multipage/scripting.html#concept-try-upgrade
[2] https://dom.spec.whatwg.org/#concept-node-insert

BUG=594918
Committed: https://crrev.com/efb4249e4e385284b1f320e9642a50fb47f2217e
Cr-Commit-Position: refs/heads/master@{#400401}

[kojii, 2016-06-14 16:44:35]

Description was changed from

==========
try-to-upgrade

BUG=
==========

to

==========
Upgrade custom elements when inserting a node

This patch upgrades custom elements when inserting an element[1], and
the definition is not null in "try to upgrade" step[2].

[1] https://dom.spec.whatwg.org/#concept-node-insert
[2] https://html.spec.whatwg.org/multipage/scripting.html#concept-try-upgrade

BUG=594918
==========

[kojii, 2016-06-15 07:32:28]

Description was changed from

==========
Upgrade custom elements when inserting a node

This patch upgrades custom elements when inserting an element[1], and
the definition is not null in "try to upgrade" step[2].

[1] https://dom.spec.whatwg.org/#concept-node-insert
[2] https://html.spec.whatwg.org/multipage/scripting.html#concept-try-upgrade

BUG=594918
==========

to

==========
Upgrade custom elements when inserting a node

This patch tries to upgrade[1] custom elements when inserting a node[2].

With this change, setting to innerHTML/outerHTML enqueues upgrade
reactions if the definition is not null, but then it calls internal
appendChild() before the reactions are invoked, which enques upgrade
reactions again. Added the guard in CustomElementDefinition::upgrade()
for such cases.

[1] https://html.spec.whatwg.org/multipage/scripting.html#concept-try-upgrade
[2] https://dom.spec.whatwg.org/#concept-node-insert

BUG=594918
==========

[kojii, 2016-06-15 07:32:56]

kojii@chromium.org changed reviewers:
+ dominicc@chromium.org

[kojii, 2016-06-15 07:32:56]

PTAL.

[kojii, 2016-06-15 15:55:21]

Description was changed from

==========
Upgrade custom elements when inserting a node

This patch tries to upgrade[1] custom elements when inserting a node[2].

With this change, setting to innerHTML/outerHTML enqueues upgrade
reactions if the definition is not null, but then it calls internal
appendChild() before the reactions are invoked, which enques upgrade
reactions again. Added the guard in CustomElementDefinition::upgrade()
for such cases.

[1] https://html.spec.whatwg.org/multipage/scripting.html#concept-try-upgrade
[2] https://dom.spec.whatwg.org/#concept-node-insert

BUG=594918
==========

to

==========
Upgrade custom elements when inserting a node

This patch tries to upgrade[1] custom elements when inserting a node[2].

With this change, setting to innerHTML/outerHTML enqueues upgrade
reactions if the definition is not null, but then
Element::insertedInto() enqueues upgrade reactions again. Added the
guard in CustomElementDefinition::upgrade() for such cases.

[1] https://html.spec.whatwg.org/multipage/scripting.html#concept-try-upgrade
[2] https://dom.spec.whatwg.org/#concept-node-insert

BUG=594918
==========

[dominicc (has gone to gerrit), 2016-06-16 05:26:41]

lgtm

LGTM, some suggestions inline.

https://codereview.chromium.org/2067853002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html
(right):

https://codereview.chromium.org/2067853002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html:15:

Delete this line?

https://codereview.chromium.org/2067853002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html:18:
assert_false(element.matches(':defined'));
This is a bit redundant given line 24?

https://codereview.chromium.org/2067853002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html:21:
constructor() { super(); this.is_upgraded = true; }
Any reason not to write this over multiple lines?

https://codereview.chromium.org/2067853002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html:29:

Delete this line?

https://codereview.chromium.org/2067853002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp
(right):

https://codereview.chromium.org/2067853002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp:19:
// Multiple upgrade reactions could be enqueued because the state changes in
This has a step number in the spec; maybe reference that in the comment?

[kojii, 2016-06-16 06:04:31]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-06-16 06:04:32]

All done, thanks for the review!

[kojii, 2016-06-16 06:04:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2067853002/#ps80001
(title: "dominicc nit")

[commit-bot: I haz the power, 2016-06-16 06:04:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067853002/80001

[commit-bot: I haz the power, 2016-06-16 09:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 09:19:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2016-06-16 09:23:13]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-06-16 09:23:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067853002/80001

[commit-bot: I haz the power, 2016-06-16 13:11:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 13:11:58]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2016-06-17 04:29:24]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-06-17 04:29:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067853002/80001

[commit-bot: I haz the power, 2016-06-17 07:22:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 07:22:52]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2016-06-17 07:39:28]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-06-17 07:39:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067853002/80001

[commit-bot: I haz the power, 2016-06-17 08:50:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-17 08:51:38]

Description was changed from

==========
Upgrade custom elements when inserting a node

This patch tries to upgrade[1] custom elements when inserting a node[2].

With this change, setting to innerHTML/outerHTML enqueues upgrade
reactions if the definition is not null, but then
Element::insertedInto() enqueues upgrade reactions again. Added the
guard in CustomElementDefinition::upgrade() for such cases.

[1] https://html.spec.whatwg.org/multipage/scripting.html#concept-try-upgrade
[2] https://dom.spec.whatwg.org/#concept-node-insert

BUG=594918
==========

to

==========
Upgrade custom elements when inserting a node

This patch tries to upgrade[1] custom elements when inserting a node[2].

With this change, setting to innerHTML/outerHTML enqueues upgrade
reactions if the definition is not null, but then
Element::insertedInto() enqueues upgrade reactions again. Added the
guard in CustomElementDefinition::upgrade() for such cases.

[1] https://html.spec.whatwg.org/multipage/scripting.html#concept-try-upgrade
[2] https://dom.spec.whatwg.org/#concept-node-insert

BUG=594918

Committed: https://crrev.com/efb4249e4e385284b1f320e9642a50fb47f2217e
Cr-Commit-Position: refs/heads/master@{#400401}
==========

[commit-bot: I haz the power, 2016-06-17 08:51:39]

Patchset 5 (id:??) landed as
https://crrev.com/efb4249e4e385284b1f320e9642a50fb47f2217e
Cr-Commit-Position: refs/heads/master@{#400401}