Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

Issue 2067853002: Upgrade custom elements when inserting a node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dominicc nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/custom/CustomElementUpgradeReaction.h" 5 #include "core/dom/custom/CustomElementUpgradeReaction.h"
6 6
7 #include "core/dom/custom/CustomElementDefinition.h" 7 #include "core/dom/custom/CustomElementDefinition.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
11 CustomElementUpgradeReaction::CustomElementUpgradeReaction( 11 CustomElementUpgradeReaction::CustomElementUpgradeReaction(
12 CustomElementDefinition* definition) 12 CustomElementDefinition* definition)
13 : CustomElementReaction(definition) 13 : CustomElementReaction(definition)
14 { 14 {
15 } 15 }
16 16
17 void CustomElementUpgradeReaction::invoke(Element* element) 17 void CustomElementUpgradeReaction::invoke(Element* element)
18 { 18 {
19 m_definition->upgrade(element); 19 // Don't call upgrade() if it's already upgraded. Multiple upgrade reactions
20 // could be enqueued because the state changes in step 10 of upgrades.
21 // https://html.spec.whatwg.org/multipage/scripting.html#upgrades
22 if (element->getCustomElementState() == CustomElementState::Undefined)
23 m_definition->upgrade(element);
20 } 24 }
21 25
22 } // namespace blink 26 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698