Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2067753002: Do not suppress referrers for '<a ... rel="noopener">'. (Closed)

Created:
4 years, 6 months ago by Mike West
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Do not suppress referrers for '<a ... rel="noopener">'. The current implementation of 'noopener' correctly split the referrer and opener states in Blink, but missed a spot higher up the stack where the two were still conflated. This patch fixes that issue, adds tests to ensure we don't regress, and refactors the Blink-side code a bit so that we're no longer passing the data around twice. BUG=618532 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2058693002 Cr-Commit-Position: refs/heads/master@{#399391} (cherry picked from commit 4c82bb5386376f64c2a8eb9258ea397cba04b7d1) Committed: https://chromium.googlesource.com/chromium/src/+/fe741d1a0c260e05e914ef8fd7ebc17956f4ef7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -21 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 3 chunks +21 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 7 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
4 years, 6 months ago (2016-06-14 07:38:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe741d1a0c260e05e914ef8fd7ebc17956f4ef7f.

Powered by Google App Engine
This is Rietveld 408576698