Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2067753002: Do not suppress referrers for '<a ... rel="noopener">'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 return getNavigationPolicy(features); 343 return getNavigationPolicy(features);
344 if (policy == WebNavigationPolicyNewBackgroundTab && getNavigationPolicy(fea tures) != WebNavigationPolicyNewBackgroundTab && !UIEventWithKeyState::newTabMod ifierSetFromIsolatedWorld()) 344 if (policy == WebNavigationPolicyNewBackgroundTab && getNavigationPolicy(fea tures) != WebNavigationPolicyNewBackgroundTab && !UIEventWithKeyState::newTabMod ifierSetFromIsolatedWorld())
345 return WebNavigationPolicyNewForegroundTab; 345 return WebNavigationPolicyNewForegroundTab;
346 346
347 return policy; 347 return policy;
348 } 348 }
349 349
350 } // namespace 350 } // namespace
351 351
352 Page* ChromeClientImpl::createWindow(LocalFrame* frame, const FrameLoadRequest& r, const WindowFeatures& features, 352 Page* ChromeClientImpl::createWindow(LocalFrame* frame, const FrameLoadRequest& r, const WindowFeatures& features,
353 NavigationPolicy navigationPolicy, ShouldSetOpener shouldSetOpener) 353 NavigationPolicy navigationPolicy)
354 { 354 {
355 if (!m_webView->client()) 355 if (!m_webView->client())
356 return nullptr; 356 return nullptr;
357 357
358 WebNavigationPolicy policy = effectiveNavigationPolicy(navigationPolicy, fea tures); 358 WebNavigationPolicy policy = effectiveNavigationPolicy(navigationPolicy, fea tures);
359 DCHECK(frame->document()); 359 DCHECK(frame->document());
360 Fullscreen::fullyExitFullscreen(*frame->document()); 360 Fullscreen::fullyExitFullscreen(*frame->document());
361 361
362 WebViewImpl* newView = toWebViewImpl( 362 WebViewImpl* newView = toWebViewImpl(
363 m_webView->client()->createView(WebLocalFrameImpl::fromFrame(frame), Wra ppedResourceRequest(r.resourceRequest()), features, r.frameName(), policy, shoul dSetOpener == NeverSetOpener)); 363 m_webView->client()->createView(WebLocalFrameImpl::fromFrame(frame), Wra ppedResourceRequest(r.resourceRequest()), features, r.frameName(), policy, r.get ShouldSetOpener() == NeverSetOpener || features.noopener));
364 if (!newView) 364 if (!newView)
365 return nullptr; 365 return nullptr;
366 return newView->page(); 366 return newView->page();
367 } 367 }
368 368
369 void ChromeClientImpl::didOverscroll(const FloatSize& overscrollDelta, const Flo atSize& accumulatedOverscroll, const FloatPoint& positionInViewport, const Float Size& velocityInViewport) 369 void ChromeClientImpl::didOverscroll(const FloatSize& overscrollDelta, const Flo atSize& accumulatedOverscroll, const FloatPoint& positionInViewport, const Float Size& velocityInViewport)
370 { 370 {
371 if (!m_webView->client()) 371 if (!m_webView->client())
372 return; 372 return;
373 373
(...skipping 734 matching lines...) Expand 10 before | Expand all | Expand 10 after
1108 { 1108 {
1109 return adoptPtr(m_webView->scheduler()->createFrameScheduler(blameContext).r elease()); 1109 return adoptPtr(m_webView->scheduler()->createFrameScheduler(blameContext).r elease());
1110 } 1110 }
1111 1111
1112 double ChromeClientImpl::lastFrameTimeMonotonic() const 1112 double ChromeClientImpl::lastFrameTimeMonotonic() const
1113 { 1113 {
1114 return m_webView->lastFrameTimeMonotonic(); 1114 return m_webView->lastFrameTimeMonotonic();
1115 } 1115 }
1116 1116
1117 } // namespace blink 1117 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698