gin/v8_isolate_memory_dump_provider.cc - Issue 2067543003: [tracing] Replace %p with %PRIXPTR in the memory dump names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/v8_isolate_memory_dump_provider.cc

Issue 2067543003: [tracing] Replace %p with %PRIXPTR in the memory dump names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix include. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/dom_storage/dom_storage_area.cc ('K') | « extensions/browser/value_store/leveldb_value_store.cc ('k') | sql/connection_memory_dump_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gin/v8_isolate_memory_dump_provider.cc

diff --git a/gin/v8_isolate_memory_dump_provider.cc b/gin/v8_isolate_memory_dump_provider.cc

index 6b26c3129621b94749c913171e0e85a76955ab37..c501ed5a1e6fea655d615bfbd073a6ca1c08fa5f 100644

--- a/gin/v8_isolate_memory_dump_provider.cc

+++ b/gin/v8_isolate_memory_dump_provider.cc

@@ -4,6 +4,7 @@

#include "gin/v8_isolate_memory_dump_provider.h"

+#include <inttypes.h>

#include <stddef.h>

#include "base/strings/stringprintf.h"

@@ -84,8 +85,9 @@ void DumpCodeStatistics(

void V8IsolateMemoryDumpProvider::DumpHeapStatistics(

const base::trace_event::MemoryDumpArgs& args,

base::trace_event::ProcessMemoryDump* process_memory_dump) {

- std::string dump_base_name =

- base::StringPrintf("v8/isolate_%p", isolate_holder_->isolate());

+ std::string dump_base_name = base::StringPrintf(

+ "v8/isolate_0x%" PRIXPTR,

+ reinterpret_cast<uintptr_t>(isolate_holder_->isolate()));

// Dump statistics of the heap's spaces.

std::string space_name_prefix = dump_base_name + "/heap_spaces";