Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: extensions/browser/value_store/leveldb_value_store.cc

Issue 2067543003: [tracing] Replace %p with %PRIXPTR in the memory dump names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix include. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/value_store/leveldb_value_store.cc
diff --git a/extensions/browser/value_store/leveldb_value_store.cc b/extensions/browser/value_store/leveldb_value_store.cc
index 6610652e3e7f884fb4d52eb2745b15b329fb6582..8384d46cd7f1b0da11a147412353719ebacc6179 100644
--- a/extensions/browser/value_store/leveldb_value_store.cc
+++ b/extensions/browser/value_store/leveldb_value_store.cc
@@ -4,6 +4,7 @@
#include "extensions/browser/value_store/leveldb_value_store.h"
+#include <inttypes.h>
#include <stdint.h>
#include <utility>
@@ -252,7 +253,8 @@ bool LeveldbValueStore::OnMemoryDump(
DCHECK(res);
auto dump = pmd->CreateAllocatorDump(base::StringPrintf(
- "leveldb/value_store/%s/%p", open_histogram_name().c_str(), this));
+ "leveldb/value_store/%s/0x%" PRIXPTR, open_histogram_name().c_str(),
+ reinterpret_cast<uintptr_t>(this)));
dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
base::trace_event::MemoryAllocatorDump::kUnitsBytes, size);

Powered by Google App Engine
This is Rietveld 408576698