content/browser/indexed_db/leveldb/leveldb_database.cc - Issue 2067543003: [tracing] Replace %p with %PRIXPTR in the memory dump names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/leveldb/leveldb_database.cc

Issue 2067543003: [tracing] Replace %p with %PRIXPTR in the memory dump names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix include. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/dom_storage/dom_storage_area.cc ('K') | « content/browser/dom_storage/session_storage_database.cc ('k') | extensions/browser/value_store/leveldb_value_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/leveldb/leveldb_database.cc

diff --git a/content/browser/indexed_db/leveldb/leveldb_database.cc b/content/browser/indexed_db/leveldb/leveldb_database.cc

index 87186ee6dceb9a32e86e363588b1315156524bb1..9126d4a0db83fd25951c1d0bbc10444e9811bb1c 100644

--- a/content/browser/indexed_db/leveldb/leveldb_database.cc

+++ b/content/browser/indexed_db/leveldb/leveldb_database.cc

@@ -4,6 +4,7 @@

#include "content/browser/indexed_db/leveldb/leveldb_database.h"

+#include <inttypes.h>

#include <stdint.h>

#include <cerrno>

@@ -460,8 +461,8 @@ bool LevelDBDatabase::OnMemoryDump(

DCHECK(res);

base::StringToUint64(value, &size);

- auto dump = pmd->CreateAllocatorDump(

- base::StringPrintf("leveldb/index_db/%p", db_.get()));

+ auto dump = pmd->CreateAllocatorDump(base::StringPrintf(

+ "leveldb/index_db/0x%" PRIXPTR, reinterpret_cast<uintptr_t>(db_.get())));

dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,

base::trace_event::MemoryAllocatorDump::kUnitsBytes, size);

dump->AddString("file_name", "", file_name_for_tracing);