Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2067513002: [turbofan] Remove some TODOs that no longer apply. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove some TODOs that no longer apply. R=bmeurer@chromium.org Committed: https://crrev.com/3b2da29532d520c11f750ecfbd86061c3142ff74 Cr-Commit-Position: refs/heads/master@{#36949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M src/compiler/access-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/wasm/wasm-result.cc View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-13 13:43:25 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-13 18:06:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067513002/1
4 years, 6 months ago (2016-06-14 07:42:49 UTC) #5
Michael Starzinger
+Andreas: Need WASM stamp.
4 years, 6 months ago (2016-06-14 07:45:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17141)
4 years, 6 months ago (2016-06-14 07:46:03 UTC) #10
ahaas
lgtm
4 years, 6 months ago (2016-06-14 07:52:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067513002/1
4 years, 6 months ago (2016-06-14 07:57:09 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 07:59:15 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 08:01:02 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b2da29532d520c11f750ecfbd86061c3142ff74
Cr-Commit-Position: refs/heads/master@{#36949}

Powered by Google App Engine
This is Rietveld 408576698