Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2064723002: Update SharedFunctionInfoVerify to new object model. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
bradnelson, rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-todos-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update SharedFunctionInfoVerify to new object model. The builtin function ID has been moved from the [function_data] field to the [function_location] field. This just updates existing verification functionality to be in sync. R=rmcilroy@chromium.org Committed: https://crrev.com/56a9df6be030c0930a21673e776b835a3690b7c8 Cr-Commit-Position: refs/heads/master@{#36951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/objects-debug.cc View 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Ross: PTAL. Brad: FYI.
4 years, 6 months ago (2016-06-13 14:43:27 UTC) #2
rmcilroy
Thanks for fixing this. Lgtm.
4 years, 6 months ago (2016-06-14 06:35:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064723002/1
4 years, 6 months ago (2016-06-14 08:55:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 08:58:20 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 08:59:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56a9df6be030c0930a21673e776b835a3690b7c8
Cr-Commit-Position: refs/heads/master@{#36951}

Powered by Google App Engine
This is Rietveld 408576698