src/debug/debug.cc - Issue 2067503002: [debugger] fix stepping over await calls for ignition generators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug.cc

Issue 2067503002: [debugger] fix stepping over await calls for ignition generators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@test

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/debug.cc

diff --git a/src/debug/debug.cc b/src/debug/debug.cc

index 09fe2fb90a3859983d643f66e2cc5754ed783420..8e0554c51c273ea419fcb7c7e933aa581e8fad4e 100644

--- a/src/debug/debug.cc

+++ b/src/debug/debug.cc

@@ -1382,8 +1382,8 @@ bool Debug::PrepareFunctionForBreakPoints(Handle<SharedFunctionInfo> shared) {

void Debug::RecordAsyncFunction(Handle<JSGeneratorObject> generator_object) {

if (last_step_action() <= StepOut) return;

+ if (!generator_object->function()->shared()->is_async()) return;

DCHECK(!has_suspended_generator());

- DCHECK(generator_object->function()->shared()->is_async());

thread_local_.suspended_generator_ = *generator_object;

ClearStepping();

}

« no previous file with comments | « src/debug/debug.h ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »