Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Side by Side Diff: src/debug/debug.cc

Issue 2067503002: [debugger] fix stepping over await calls for ignition generators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@test
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.h ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1364 matching lines...) Expand 10 before | Expand all | Expand 10 after
1375 // Update PCs on the stack to point to recompiled code. 1375 // Update PCs on the stack to point to recompiled code.
1376 RedirectActiveFunctions redirect_visitor(*shared); 1376 RedirectActiveFunctions redirect_visitor(*shared);
1377 redirect_visitor.VisitThread(isolate_, isolate_->thread_local_top()); 1377 redirect_visitor.VisitThread(isolate_, isolate_->thread_local_top());
1378 isolate_->thread_manager()->IterateArchivedThreads(&redirect_visitor); 1378 isolate_->thread_manager()->IterateArchivedThreads(&redirect_visitor);
1379 1379
1380 return true; 1380 return true;
1381 } 1381 }
1382 1382
1383 void Debug::RecordAsyncFunction(Handle<JSGeneratorObject> generator_object) { 1383 void Debug::RecordAsyncFunction(Handle<JSGeneratorObject> generator_object) {
1384 if (last_step_action() <= StepOut) return; 1384 if (last_step_action() <= StepOut) return;
1385 if (!generator_object->function()->shared()->is_async()) return;
1385 DCHECK(!has_suspended_generator()); 1386 DCHECK(!has_suspended_generator());
1386 DCHECK(generator_object->function()->shared()->is_async());
1387 thread_local_.suspended_generator_ = *generator_object; 1387 thread_local_.suspended_generator_ = *generator_object;
1388 ClearStepping(); 1388 ClearStepping();
1389 } 1389 }
1390 1390
1391 class SharedFunctionInfoFinder { 1391 class SharedFunctionInfoFinder {
1392 public: 1392 public:
1393 explicit SharedFunctionInfoFinder(int target_position) 1393 explicit SharedFunctionInfoFinder(int target_position)
1394 : current_candidate_(NULL), 1394 : current_candidate_(NULL),
1395 current_candidate_closure_(NULL), 1395 current_candidate_closure_(NULL),
1396 current_start_position_(RelocInfo::kNoPosition), 1396 current_start_position_(RelocInfo::kNoPosition),
(...skipping 1195 matching lines...) Expand 10 before | Expand all | Expand 10 after
2592 } 2592 }
2593 2593
2594 2594
2595 void LockingCommandMessageQueue::Clear() { 2595 void LockingCommandMessageQueue::Clear() {
2596 base::LockGuard<base::Mutex> lock_guard(&mutex_); 2596 base::LockGuard<base::Mutex> lock_guard(&mutex_);
2597 queue_.Clear(); 2597 queue_.Clear();
2598 } 2598 }
2599 2599
2600 } // namespace internal 2600 } // namespace internal
2601 } // namespace v8 2601 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/debug.h ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698