chrome/android/java/res/layout/password_entry_editor_interactive.xml - Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor

Unified Diff: chrome/android/java/res/layout/password_entry_editor_interactive.xml

Issue 2067323004: Allow copying and viewing account credentials in PasswordEntryEditor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move reauthentication functionality to PasswordEntryEditor, implement copying for link and username Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/password_entry_editor.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/password_entry_editor_interactive.xml

diff --git a/chrome/android/java/res/layout/password_entry_editor_interactive.xml b/chrome/android/java/res/layout/password_entry_editor_interactive.xml

index 4b5540160f013c40c98133371bfe205d8d9c8f18..738ac7d8db2df4e048d4ad0e925bf62df92e9139 100644

--- a/chrome/android/java/res/layout/password_entry_editor_interactive.xml

+++ b/chrome/android/java/res/layout/password_entry_editor_interactive.xml

@@ -13,8 +13,7 @@

android:layout_width="match_parent"

android:layout_height="wrap_content"

android:orientation="vertical"

- android:title="@string/password_entry_editor_title"

- android:visibility="gone">

+ android:title="@string/password_entry_editor_title">

<TextView

android:text="@string/password_entry_editor_site_title"

@@ -46,7 +45,9 @@

android:layout_weight="1" />

<ImageButton

+ android:id="@+id/password_entry_editor_copy_site"

style="?android:attr/buttonStyleSmall"

+ android:background="#0000"

android:layout_width="match_parent"

android:layout_height="wrap_content"

android:layout_gravity="end"

@@ -88,7 +89,9 @@

android:layout_weight="1" />

<ImageButton

+ android:id="@+id/password_entry_editor_copy_username"

style="?android:attr/buttonStyleSmall"

+ android:background="#0000"

android:layout_width="match_parent"

android:layout_height="wrap_content"

android:layout_gravity="end"

@@ -128,6 +131,8 @@

android:layout_weight="1" />

<ImageButton

+ android:id="@+id/password_entry_editor_view_password"

+ android:background="#0000"

style="?android:attr/buttonStyleSmall"

android:layout_width="match_parent"

android:layout_height="wrap_content"

@@ -138,6 +143,8 @@

android:contentDescription="@string/password_entry_editor_view_stored_password" />

<ImageButton

+ android:id="@+id/password_entry_editor_copy_password"

+ android:background="#0000"

melandory 2016/07/26 22:27:29 You can define constant for the color: https://cs.

dozsa 2016/07/27 19:04:44 Done.

style="?android:attr/buttonStyleSmall"

android:layout_width="match_parent"

android:layout_height="wrap_content"