Allow copying and viewing account credentials in PasswordEntryEditor

chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
index 4e818500012fee1e1e5f8f608e09fcc79644a4b3..46b1eefa9f6700b1a5931b08151272bb6bb08f2b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
@@ -50,8 +50,19 @@ public class MainPreferences extends PreferenceFragment implements SignInStateOb
     private SignInPreference mSignInPreference;
     private ManagedPreferenceDelegate mManagedPreferenceDelegate;
 
+    // Used for verifying if 60 seconds have passed since last authenticating.
+    private static long sStartTime = 0;

[vabr (Chromium), 2016/07/26 20:03:18]

nit: What are the units? Also, "start time" implies a timestamp rather than a
time duration. What about sTimeSinceReauthMillis or something similar (assuming
that the units are milliseconds, which the current callsite of setStartTime
indicates).

[dozsa, 2016/07/27 19:04:44]

I'll be using sStartTime to register the time at which the user entered their
device lock, and then whenever they request to view/copy a password, I'll
calculate the difference between the current time and sStartTime. If it's
greater than 30 seconds, they'll be requested to enter their password again.

[vabr (Chromium), 2016/07/28 09:44:33]

Ah, good point about this being indeed a time stamp. The name is still not
ideal, though. In the context of MainPreferences, "start time" does not give
much clue that this is a timetampf of the last reauthentication.

You should still capture the units, though. Your code in PEE.java indicates that
the timestampt is in milliseconds, so the suffix should be Millis.

Given the above, my suggestion would be something like:
sLastReauthTimeMillis.

+
     private boolean mShowSearchEnginePicker;
 
+    public static void setStartTime(long value) {
+        sStartTime = value;
+    }
+
+    public static long getStartTime() {
+        return sStartTime;
+    }
+
     public MainPreferences() {
         setHasOptionsMenu(true);
         mManagedPreferenceDelegate = createManagedPreferenceDelegate();