Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2067263002: Increment download_file_types version since I missed it before (Closed)

Created:
4 years, 6 months ago by Nathan Parker
Modified:
4 years, 6 months ago
Reviewers:
jialiul, Jialiu Lin
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increment download_file_types version since I missed it before I missed this in https://codereview.chromium.org/2051213003 and hence it wont get pushed till I land+push this. R=jialiul BUG=600907 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e5a6877b2df8b2cc36e959285e095df410e734cf Cr-Commit-Position: refs/heads/master@{#399950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/safe_browsing/download_file_types.asciipb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Nathan Parker
4 years, 6 months ago (2016-06-15 16:38:40 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067263002/1
4 years, 6 months ago (2016-06-15 16:40:16 UTC) #4
Jialiu Lin
lgtm
4 years, 6 months ago (2016-06-15 16:42:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067263002/1
4 years, 6 months ago (2016-06-15 17:04:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 17:58:47 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 17:59:02 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 18:01:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5a6877b2df8b2cc36e959285e095df410e734cf
Cr-Commit-Position: refs/heads/master@{#399950}

Powered by Google App Engine
This is Rietveld 408576698