Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2051213003: Add additional compressed formats for Mac OS (Closed)

Created:
4 years, 6 months ago by Nathan Parker
Modified:
4 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add additional compressed formats for Mac OS R=vakh BUG=600907 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8e11fd0f247034347d72abd6b8c29cfec6074b16 Cr-Commit-Position: refs/heads/master@{#399208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M chrome/browser/resources/safe_browsing/download_file_types.asciipb View 3 chunks +46 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Nathan Parker
4 years, 6 months ago (2016-06-09 21:29:10 UTC) #1
vakh (use Gerrit instead)
lgtm
4 years, 6 months ago (2016-06-09 21:33:18 UTC) #3
vakh (use Gerrit instead)
With the updatable component working now, are we going to maintain the list in chrome/common/safe_browsing/download_protection_util.cc ...
4 years, 6 months ago (2016-06-09 21:35:18 UTC) #4
Nathan Parker
On 2016/06/09 21:35:18, vakh wrote: > With the updatable component working now, are we going ...
4 years, 6 months ago (2016-06-10 00:02:57 UTC) #5
Nathan Parker
holte: Please review the four lines added to histograms.xml. Thanks.
4 years, 6 months ago (2016-06-10 00:04:01 UTC) #7
Steven Holte
lgtm
4 years, 6 months ago (2016-06-10 00:32:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051213003/1
4 years, 6 months ago (2016-06-10 16:36:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 16:48:03 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 16:48:12 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 16:49:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e11fd0f247034347d72abd6b8c29cfec6074b16
Cr-Commit-Position: refs/heads/master@{#399208}

Powered by Google App Engine
This is Rietveld 408576698