Cleanup XML parser code.

Cleanup XML parser code.

This Cl removes the CFDE_XMLSAXParser and CFDE_XMLDOMParser along with the
::LoadXML() method which would create them, it was never called. It also
cleans up the use of virtual in the various XML classes.

Committed: https://pdfium.googlesource.com/pdfium/+/3fa3351c90332cd51e67bf4624c57bd0ba78e4a6

[dsinclair, 2016-06-15 16:13:38]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-06-15 16:13:38]

PTAL.

[Lei Zhang, 2016-06-15 19:35:53]

lgtm

https://codereview.chromium.org/2067253002/diff/1/xfa/fde/xml/fde_xml_imp.h
File xfa/fde/xml/fde_xml_imp.h (right):

https://codereview.chromium.org/2067253002/diff/1/xfa/fde/xml/fde_xml_imp.h#n...
xfa/fde/xml/fde_xml_imp.h:322: inline void ParseTextChar(FX_WCHAR ch);
no inline?

[dsinclair, 2016-06-16 14:26:57]

https://codereview.chromium.org/2067253002/diff/1/xfa/fde/xml/fde_xml_imp.h
File xfa/fde/xml/fde_xml_imp.h (right):

https://codereview.chromium.org/2067253002/diff/1/xfa/fde/xml/fde_xml_imp.h#n...
xfa/fde/xml/fde_xml_imp.h:322: inline void ParseTextChar(FX_WCHAR ch);
On 2016/06/15 19:35:52, Lei Zhang wrote:
> no inline?

Done.

[dsinclair, 2016-06-16 14:27:00]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-16 14:27:01]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2067253002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-06-16 14:27:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067253002/20001

[commit-bot: I haz the power, 2016-06-16 14:45:27]

Description was changed from

==========
Cleanup XML parser code.

This Cl removes the CFDE_XMLSAXParser and CFDE_XMLDOMParser along with the
::LoadXML() method which would create them, it was never called. It also
cleans up the use of virtual in the various XML classes.
==========

to

==========
Cleanup XML parser code.

This Cl removes the CFDE_XMLSAXParser and CFDE_XMLDOMParser along with the
::LoadXML() method which would create them, it was never called. It also
cleans up the use of virtual in the various XML classes.

Committed:
https://pdfium.googlesource.com/pdfium/+/3fa3351c90332cd51e67bf4624c57bd0ba78...
==========

[commit-bot: I haz the power, 2016-06-16 14:45:28]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/3fa3351c90332cd51e67bf4624c57bd0ba78...