xfa/fxfa/parser/xfa_parser_imp.h - Issue 2067253002: Cleanup XML parser code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_parser_imp.h

Issue 2067253002: Cleanup XML parser code. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Review feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_parser_imp.h

diff --git a/xfa/fxfa/parser/xfa_parser_imp.h b/xfa/fxfa/parser/xfa_parser_imp.h

index 2485ddfcd27143efdbb87e7f6dacb667de36c664..1f117be64ed246e98d41894ddf161837426d581b 100644

--- a/xfa/fxfa/parser/xfa_parser_imp.h

+++ b/xfa/fxfa/parser/xfa_parser_imp.h

@@ -109,7 +109,6 @@ class CXFA_DocumentParser : public IXFA_Parser {

CXFA_FFNotify* m_pNotify;

CXFA_Document* m_pDocument;

};

-typedef CFX_StackTemplate<CFDE_XMLNode*> CXFA_XMLNodeStack;

class CXFA_XMLParser : public CFDE_XMLParser {

public:

@@ -131,7 +130,7 @@ class CXFA_XMLParser : public CFDE_XMLParser {

CFDE_XMLSyntaxParser* m_pParser;

CFDE_XMLNode* m_pParent;

CFDE_XMLNode* m_pChild;

- CXFA_XMLNodeStack m_NodeStack;

+ CFX_StackTemplate<CFDE_XMLNode*> m_NodeStack;

CFX_WideString m_ws1;

CFX_WideString m_ws2;

FDE_XmlSyntaxResult m_syntaxParserResult;

« no previous file with comments | « xfa/fxfa/parser/xfa_parser.h ('k') | xfa/fxfa/parser/xfa_utils.h » ('j') | no next file with comments »