Issue 20672004: Implement onGetTableTags and onGetTableData on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20672004: Implement onGetTableTags and onGetTableData on Windows. (Closed)

Created:
7 years, 4 months ago by bungeman-skia

Modified:
7 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Implement onGetTableTags and onGetTableData on Windows. Implements these and removes default implementation, making the declaration in SkTypeface pure virtual. Committed: https://code.google.com/p/skia/source/detail?r=10500

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -47 lines)			Patch
M	include/core/SkTypeface.h	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	src/core/SkTypeface.cpp	View	1	2 chunks	+0 lines, -16 lines	0 comments	Download
M	src/ports/SkFontConfigTypeface.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	1	2 chunks	+56 lines, -2 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType_common.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ports/SkFontHost_fontconfig.cpp	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

Committed patchset #2 manually as r10500 (presubmit successful).

7 years, 4 months ago (2013-08-01 22:29:47 UTC) #1

reed1

change looks good. It appears that you changed code for the fontconfig backend, but the ...

7 years, 4 months ago (2013-08-02 13:45:58 UTC) #2

bungeman-skia

7 years, 4 months ago (2013-08-02 13:58:09 UTC) #3

Message was sent while issue was closed.

On 2013/08/02 13:45:58, reed1 wrote:
> but the CL comment says Windows.

Arg, yes, I changed it and then gclient changed it back. Next time I will ensure
that they're all changed before committing.

Expand Messages | Collapse Messages