Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: include/core/SkTypeface.h

Issue 20672004: Implement onGetTableTags and onGetTableData on Windows. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkTypeface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkTypeface.h
===================================================================
--- include/core/SkTypeface.h (revision 10497)
+++ include/core/SkTypeface.h (working copy)
@@ -22,6 +22,7 @@
class SkWStream;
typedef uint32_t SkFontID;
+/** Machine endian. */
typedef uint32_t SkFontTableTag;
/** \class SkTypeface
@@ -294,16 +295,11 @@
virtual int onGetUPEM() const = 0;
- virtual int onGetTableTags(SkFontTableTag tags[]) const;
+ virtual int onGetTableTags(SkFontTableTag tags[]) const = 0;
virtual size_t onGetTableData(SkFontTableTag, size_t offset,
- size_t length, void* data) const;
+ size_t length, void* data) const = 0;
- // TODO: make this pure-virtual when all ports have overridden it
- virtual SkTypeface* onRefMatchingStyle(Style styleBits) const {
- SkASSERT(0);
- this->ref();
- return const_cast<SkTypeface*>(this);
- }
+ virtual SkTypeface* onRefMatchingStyle(Style styleBits) const = 0;
private:
SkFontID fUniqueID;
« no previous file with comments | « no previous file | src/core/SkTypeface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698