chrome/test/base/web_ui_browser_test.cc - Issue 2067153002: ChromeOS: Implement Network Selection screen of material design OOBE.

Unified Diff: chrome/test/base/web_ui_browser_test.cc

Issue 2067153002: ChromeOS: Implement Network Selection screen of material design OOBE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update after review. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/login/oobe_welcome.js ('K') | « chrome/browser/ui/webui/chromeos/network_ui.cc ('k') | extensions/common/api/_api_features.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/web_ui_browser_test.cc

diff --git a/chrome/test/base/web_ui_browser_test.cc b/chrome/test/base/web_ui_browser_test.cc

index 4a55e86fc2e041d9b37aca86663e4c6dc6f2a426..77af67c2b0f92bd976e263969e66b13e13f3b59c 100644

--- a/chrome/test/base/web_ui_browser_test.cc

+++ b/chrome/test/base/web_ui_browser_test.cc

@@ -458,6 +458,10 @@ bool WebUIBrowserTest::RunJavascriptUsingHandler(

else

test_handler_->RunJavaScript(content);

+ for (const auto& msg : error_messages_.Get()) {

Paweł Hajdan Jr. 2016/07/11 15:37:38 Consider extracting this change to a separate CL.

stevenjb 2016/07/11 16:37:23 +1, I like the idea behind the change, but agree t

Alexander Alekseev 2016/07/12 04:12:14 Done.

Alexander Alekseev 2016/07/12 04:12:14 I moved this change to amother CL: https://coderev

+ LOG(ERROR) << "Encountered javascript console error: '" << msg << "'";

+ }

if (error_messages_.Get().size() > 0) {

LOG(ERROR) << "Encountered javascript console error(s)";

result = false;