ChromeOS: Implement Network Selection screen of material design OOBE.

chrome/test/base/web_ui_browser_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/web_ui_browser_test.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
@@ skipping 440 matching lines @@
   for (size_t i = 0; i < libraries.size(); ++i)
     test_handler_->PreloadJavaScript(libraries[i], preload_host);
 
   if (is_test)
     result = test_handler_->RunJavaScriptTestWithResult(content);
   else if (preload_host)
     test_handler_->PreloadJavaScript(content, preload_host);
   else
     test_handler_->RunJavaScript(content);
 
+  for (const auto& msg : error_messages_.Get()) {

[Paweł Hajdan Jr., 2016/07/11 15:37:38]

Consider extracting this change to a separate CL.

Why not change "Encountered javascript console error(s)" code below instead?
They operate on the same error_messages_ member variable.

By the way, more debugging info this way is a great idea. I like the change.

[stevenjb, 2016/07/11 16:37:23]

+1, I like the idea behind the change, but agree that we should do this
separately and integrate it with the if clause below, e.g:

Encountered javascript console error(s):
JS ERROR: <first error>
etc

(or something similar)

[Alexander Alekseev, 2016/07/12 04:12:14]

Done.

[Alexander Alekseev, 2016/07/12 04:12:14]

I moved this change to amother CL: https://codereview.chromium.org/2145493002/ .

+    LOG(ERROR) << "Encountered javascript console error: '" << msg << "'";
+  }
+
   if (error_messages_.Get().size() > 0) {
     LOG(ERROR) << "Encountered javascript console error(s)";
     result = false;
     error_messages_.Get().clear();
   }
   return result;
 }
 
 void WebUIBrowserTest::SetupHandlers() {
   content::WebUI* web_ui_instance =
@@ skipping 12 matching lines @@
 }
 
 GURL WebUIBrowserTest::WebUITestDataPathToURL(
     const base::FilePath::StringType& path) {
   base::FilePath dir_test_data;
   EXPECT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &dir_test_data));
   base::FilePath test_path(dir_test_data.Append(kWebUITestFolder).Append(path));
   EXPECT_TRUE(base::PathExists(test_path));
   return net::FilePathToFileURL(test_path);
 }