chrome/plugin/chrome_content_plugin_client.cc - Issue 206713004: Report PPAPI plugin load error code to UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/plugin/chrome_content_plugin_client.cc

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use std::string directly. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/plugin/chrome_content_plugin_client.cc

diff --git a/chrome/plugin/chrome_content_plugin_client.cc b/chrome/plugin/chrome_content_plugin_client.cc

index 4e1dee7d4b1e43f2835e6bf5feb0d5e140cb386d..a16fa163cff28caf30dc47cd9d26db1575034523 100644

--- a/chrome/plugin/chrome_content_plugin_client.cc

+++ b/chrome/plugin/chrome_content_plugin_client.cc

@@ -30,7 +30,7 @@ void ChromeContentPluginClient::PreSandboxInitialization() {

crypto::EnsureNSSInit();

#elif defined(OS_WIN)

// crypt32.dll is used to decode X509 certificates for Chromoting.

- std::string error;

+ base::NativeLibraryLoadError error = 0;

if (base::LoadNativeLibrary(base::FilePath(L"crypt32.dll"), &error) == NULL)

LOG(ERROR) << "Failed to load crypto32.dll: " << error;

#endif // defined(OS_WIN)