Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: base/native_library_posix.cc

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: BASE_EXPORT Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/native_library_mac.mm ('k') | base/native_library_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/native_library_posix.cc
diff --git a/base/native_library_posix.cc b/base/native_library_posix.cc
index dfa20fc01cf78ef6ab2061f3eefb32d3c8f324c0..3179a93833c0ad20beafe800d8e24d3a21d127b5 100644
--- a/base/native_library_posix.cc
+++ b/base/native_library_posix.cc
@@ -13,9 +13,13 @@
namespace base {
+std::string NativeLibraryLoadError::ToString() const {
+ return message;
+}
+
// static
NativeLibrary LoadNativeLibrary(const FilePath& library_path,
- std::string* error) {
+ NativeLibraryLoadError* error) {
// dlopen() opens the file off disk.
base::ThreadRestrictions::AssertIOAllowed();
@@ -25,7 +29,7 @@ NativeLibrary LoadNativeLibrary(const FilePath& library_path,
// and http://crbug.com/40794.
void* dl = dlopen(library_path.value().c_str(), RTLD_LAZY);
if (!dl && error)
- *error = dlerror();
+ error->message = dlerror();
return dl;
}
« no previous file with comments | « base/native_library_mac.mm ('k') | base/native_library_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698