Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: base/native_library_mac.mm

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: BASE_EXPORT Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/native_library.h ('k') | base/native_library_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/native_library_mac.mm
diff --git a/base/native_library_mac.mm b/base/native_library_mac.mm
index 6544fcaed99eaf644bd36da96bdd864e8bd39327..6696454c6efc0fe0ba9bf6eae6e1dfa6b3a2f2cf 100644
--- a/base/native_library_mac.mm
+++ b/base/native_library_mac.mm
@@ -41,9 +41,14 @@ static NativeLibraryObjCStatus GetObjCStatusForImage(
return section == NULL ? OBJC_NOT_PRESENT : OBJC_PRESENT;
}
+std::string NativeLibraryLoadError::ToString() const {
+ return message;
+}
+
// static
+// TODO(xhwang): Fill |error|. See http://crbug.com/353771
NativeLibrary LoadNativeLibrary(const base::FilePath& library_path,
- std::string* error) {
+ NativeLibraryLoadError* /* error */) {
// dlopen() etc. open the file off disk.
if (library_path.Extension() == "dylib" || !DirectoryExists(library_path)) {
void* dylib = dlopen(library_path.value().c_str(), RTLD_LAZY);
« no previous file with comments | « base/native_library.h ('k') | base/native_library_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698