Chromium Code Reviews| Index: base/native_library.h |
| diff --git a/base/native_library.h b/base/native_library.h |
| index d7513d0b050e181b4df913e276b39051aef5318f..d5a18130a2753b64e1da38bfda236fbf733216a6 100644 |
| --- a/base/native_library.h |
| +++ b/base/native_library.h |
| @@ -50,11 +50,14 @@ typedef NativeLibraryStruct* NativeLibrary; |
| typedef void* NativeLibrary; |
| #endif // OS_* |
| -// Loads a native library from disk. Release it with UnloadNativeLibrary when |
| +// Loads a native library from disk. Releases it with UnloadNativeLibrary when |
|
ddorwin
2014/03/21 04:20:06
"Release" was correct. Maybe "The caller must rele
xhwang
2014/03/21 17:09:18
Done.
|
| // you're done. Returns NULL on failure. |
| -// If |error| is not NULL, it may be filled in with an error message on error. |
| +// If |error_message| or |error_code| is not NULL, they may be filled in with |
| +// an error message or an error code respectively on load error if the platform |
|
ddorwin
2014/03/21 04:20:06
nit:
, respectively,
xhwang
2014/03/21 17:09:18
Done.
|
| +// supports it. |
| BASE_EXPORT NativeLibrary LoadNativeLibrary(const FilePath& library_path, |
| - std::string* error); |
| + std::string* error_message, |
| + uint32* error_code = NULL); |
| #if defined(OS_WIN) |
| // Loads a native library from disk. Release it with UnloadNativeLibrary when |