Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: base/native_library.h

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments addressed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/native_library_mac.mm » ('j') | content/ppapi_plugin/ppapi_thread.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/native_library.h
diff --git a/base/native_library.h b/base/native_library.h
index d7513d0b050e181b4df913e276b39051aef5318f..d5a18130a2753b64e1da38bfda236fbf733216a6 100644
--- a/base/native_library.h
+++ b/base/native_library.h
@@ -50,11 +50,14 @@ typedef NativeLibraryStruct* NativeLibrary;
typedef void* NativeLibrary;
#endif // OS_*
-// Loads a native library from disk. Release it with UnloadNativeLibrary when
+// Loads a native library from disk. Releases it with UnloadNativeLibrary when
ddorwin 2014/03/21 04:20:06 "Release" was correct. Maybe "The caller must rele
xhwang 2014/03/21 17:09:18 Done.
// you're done. Returns NULL on failure.
-// If |error| is not NULL, it may be filled in with an error message on error.
+// If |error_message| or |error_code| is not NULL, they may be filled in with
+// an error message or an error code respectively on load error if the platform
ddorwin 2014/03/21 04:20:06 nit: , respectively,
xhwang 2014/03/21 17:09:18 Done.
+// supports it.
BASE_EXPORT NativeLibrary LoadNativeLibrary(const FilePath& library_path,
- std::string* error);
+ std::string* error_message,
+ uint32* error_code = NULL);
#if defined(OS_WIN)
// Loads a native library from disk. Release it with UnloadNativeLibrary when
« no previous file with comments | « no previous file | base/native_library_mac.mm » ('j') | content/ppapi_plugin/ppapi_thread.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698