Report PPAPI plugin load error code to UMA.

base/native_library.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_NATIVE_LIBRARY_H_
 #define BASE_NATIVE_LIBRARY_H_
 
 // This file defines a cross-platform "NativeLibrary" type which represents
 // a loadable module.
 
@@ skipping 32 matching lines @@
   union {
     CFBundleRef bundle;
     void* dylib;
   };
 };
 typedef NativeLibraryStruct* NativeLibrary;
 #elif defined(OS_POSIX)
 typedef void* NativeLibrary;
 #endif  // OS_*
 
-// Loads a native library from disk.  Release it with UnloadNativeLibrary when
+// Loads a native library from disk.  Releases it with UnloadNativeLibrary when

[ddorwin, 2014/03/21 04:20:06]

"Release" was correct. Maybe "The caller must release..." would be clearer.

[xhwang, 2014/03/21 17:09:18]

Done.

 // you're done.  Returns NULL on failure.
-// If |error| is not NULL, it may be filled in with an error message on error.
+// If |error_message| or |error_code| is not NULL, they may be filled in with
+// an error message or an error code respectively on load error if the platform

[ddorwin, 2014/03/21 04:20:06]

nit:
, respectively,

[xhwang, 2014/03/21 17:09:18]

Done.

+// supports it.
 BASE_EXPORT NativeLibrary LoadNativeLibrary(const FilePath& library_path,
-                                            std::string* error);
+                                            std::string* error_message,
+                                            uint32* error_code = NULL);
 
 #if defined(OS_WIN)
 // Loads a native library from disk.  Release it with UnloadNativeLibrary when
 // you're done.
 // This function retrieves the LoadLibrary function exported from kernel32.dll
 // and calls it instead of directly calling the LoadLibrary function via the
 // import table.
 BASE_EXPORT NativeLibrary LoadNativeLibraryDynamically(
     const FilePath& library_path);
 #endif  // OS_WIN
 
 // Unloads a native library.
 BASE_EXPORT void UnloadNativeLibrary(NativeLibrary library);
 
 // Gets a function pointer from a native library.
 BASE_EXPORT void* GetFunctionPointerFromNativeLibrary(NativeLibrary library,
                                                       const char* name);
 
 // Returns the full platform specific name for a native library.
 // For example:
 // "mylib" returns "mylib.dll" on Windows, "libmylib.so" on Linux,
 // "mylib.dylib" on Mac.
 BASE_EXPORT string16 GetNativeLibraryName(const string16& name);
 
 }  // namespace base
 
 #endif  // BASE_NATIVE_LIBRARY_H_