Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2067013002: Removed InkDropFactory. (Closed)

Created:
4 years, 6 months ago by bruthig
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asanka, tfarina, dcheng, bruthig+ink_drop_chromium.org, noyau+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed InkDropFactory. The InkDropFactory used the ui::MaterialDesignController to decide which type of InkDrop should be created. This prevented ash surfaces from getting an ink drop when the top chrome material mode was turned off. i.e. the ash::MaterialDesignController and ui::MaterialDesignController should be able to change their modes independantly. BUG=None Committed: https://crrev.com/0ebc78a0e2cfebb908d58135e0904dff384e9671 Cr-Commit-Position: refs/heads/master@{#400188}

Patch Set 1 #

Patch Set 2 : Fixed views:: -> ui:: compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -292 lines) Patch
M chrome/browser/ui/views/bar_control_button.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view_md.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/bubble_icon_view.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/base/material_design/material_design_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
D ui/views/animation/ink_drop_factory.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/views/animation/ink_drop_factory.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/views/animation/ink_drop_factory_unittest.cc View 1 chunk +0 lines, -158 lines 0 comments Download
M ui/views/animation/ink_drop_host_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_stub.h View 1 chunk +2 lines, -1 line 0 comments Download
A + ui/views/animation/ink_drop_unittest.cc View 6 chunks +33 lines, -47 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
bruthig
estade@, can you take a look? Am I correct that the MdTextButton should ALWAYS have ...
4 years, 6 months ago (2016-06-14 21:11:16 UTC) #2
mohsen
On 2016/06/14 at 21:11:16, bruthig wrote: > estade@, can you take a look? Am I ...
4 years, 6 months ago (2016-06-15 16:09:25 UTC) #3
Evan Stade
lgtm I'm not sure why you need ash::MDC and ui::MDC to be independent but I'm ...
4 years, 6 months ago (2016-06-15 17:15:16 UTC) #4
bruthig
sadrul@chromium.org: Please review changes in - ui/base/material_design/material_design_controller.cc - ui/views/views.gyp pkasting@chromium.org: Please review changes in: - ...
4 years, 6 months ago (2016-06-15 17:56:55 UTC) #6
Peter Kasting
LGTM
4 years, 6 months ago (2016-06-16 06:20:21 UTC) #7
sadrul
On 2016/06/15 17:56:55, bruthig wrote: > mailto:sadrul@chromium.org: Please review changes in > - ui/base/material_design/material_design_controller.cc > ...
4 years, 6 months ago (2016-06-16 15:58:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067013002/20001
4 years, 6 months ago (2016-06-16 15:59:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 17:22:52 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 17:25:05 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ebc78a0e2cfebb908d58135e0904dff384e9671
Cr-Commit-Position: refs/heads/master@{#400188}

Powered by Google App Engine
This is Rietveld 408576698