REGRESSION: Click on focused link should not remove focus on it.

Source/core/svg/SVGStyledElement.cpp

Index: Source/core/svg/SVGStyledElement.cpp
diff --git a/Source/core/svg/SVGStyledElement.cpp b/Source/core/svg/SVGStyledElement.cpp
index 5f57599a31e00f40010119333558e346e2234a9b..01a2dd7de77ea6b256314aa002c01c830daf99d3 100644
--- a/Source/core/svg/SVGStyledElement.cpp
+++ b/Source/core/svg/SVGStyledElement.cpp
@@ -469,17 +469,20 @@ void SVGStyledElement::updateRelativeLengthsInformation(bool hasRelativeLengths,
     }
 }
 
-bool SVGStyledElement::isMouseFocusable() const
+bool SVGStyledElement::hasFocusEventListeners() const
 {
-    if (!isFocusable())
-        return false;
     Element* eventTarget = const_cast<SVGStyledElement *>(this);

[Stephen Chennney, 2013/07/26 14:31:14]

This should be toSVGStyledElement, but is it even necessary since you're storing
an Element?

Also, SVGStyledElement is going away, so if possible all this should be in
SVGElement.

[tkent, 2013/07/28 23:42:18]

The purpose of this case is to get non-const |this| because hasEventListeners is
not a const function. We don't have toSVG*Element function for const_cast.

Ok, I moved these functions to SVGElement.

     return eventTarget->hasEventListeners(eventNames().focusinEvent) || eventTarget->hasEventListeners(eventNames().focusoutEvent);
 }
 
+bool SVGStyledElement::isMouseFocusable() const
+{
+    return isFocusable();
+}
+
 bool SVGStyledElement::isKeyboardFocusable(KeyboardEvent*) const
 {
-    return isMouseFocusable();
+    return isFocusable();
 }
 
 }