REGRESSION: Click on focused link should not remove focus on it.

Source/core/svg/SVGStyledElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 451 matching lines @@
             node = node->parentNode();
             continue;
         }
 
         // Register us in the parent element map.
         toSVGStyledElement(element)->updateRelativeLengthsInformation(hasRelativeLengths, this);
         break;
     }
 }
 
+bool SVGStyledElement::hasFocusEventListeners() const
+{
+    Element* eventTarget = const_cast<SVGStyledElement *>(this);

[Stephen Chennney, 2013/07/26 14:31:14]

This should be toSVGStyledElement, but is it even necessary since you're storing
an Element?

Also, SVGStyledElement is going away, so if possible all this should be in
SVGElement.

[tkent, 2013/07/28 23:42:18]

The purpose of this case is to get non-const |this| because hasEventListeners is
not a const function. We don't have toSVG*Element function for const_cast.

Ok, I moved these functions to SVGElement.

+    return eventTarget->hasEventListeners(eventNames().focusinEvent) || eventTarget->hasEventListeners(eventNames().focusoutEvent);
+}
+
 bool SVGStyledElement::isMouseFocusable() const
 {
-    if (!isFocusable())
-        return false;
-    Element* eventTarget = const_cast<SVGStyledElement *>(this);
-    return eventTarget->hasEventListeners(eventNames().focusinEvent) || eventTarget->hasEventListeners(eventNames().focusoutEvent);
+    return isFocusable();
 }
 
 bool SVGStyledElement::isKeyboardFocusable(KeyboardEvent*) const
 {
-    return isMouseFocusable();
+    return isFocusable();
 }
 
 }