Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2066913002: swarming-cipd: fix for Windows (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 6 months ago
Reviewers:
Vadim Sh., M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming-cipd: fix for Windows Fix cipd.py for Windows: it cannot delete cipd.exe because the file is readonly. DiskCache insists on files be read only, so make it writable right before deletion R=maruel@chromium.org, vadimsh@chromium.org BUG=601022 Committed: https://github.com/luci/luci-py/commit/67813a2b5c1569fca9644e02680c984c90d1ccb0

Patch Set 1 #

Total comments: 2

Patch Set 2 : file_path.remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M client/cipd.py View 1 1 chunk +1 line, -1 line 0 comments Download
M client/utils/file_path.py View 1 1 chunk +14 lines, -9 lines 0 comments Download

Dependent Patchsets:

Issue 2069903003 Patch 1
Issue 2069903003 Patch 40001
Issue 2069903003 Patch 60001
Issue 2069903003 Patch 80001
Issue 2069903003 Patch 100001

Messages

Total messages: 8 (2 generated)
nodir
PTAL
4 years, 6 months ago (2016-06-14 18:07:12 UTC) #1
M-A Ruel
https://codereview.chromium.org/2066913002/diff/1/client/cipd.py File client/cipd.py (right): https://codereview.chromium.org/2066913002/diff/1/client/cipd.py#newcode401 client/cipd.py:401: fs.chmod(0711, binary_path) file_path.try_remove() does it automatically.
4 years, 6 months ago (2016-06-14 18:17:46 UTC) #2
nodir
https://codereview.chromium.org/2066913002/diff/1/client/cipd.py File client/cipd.py (right): https://codereview.chromium.org/2066913002/diff/1/client/cipd.py#newcode401 client/cipd.py:401: fs.chmod(0711, binary_path) On 2016/06/14 18:17:46, M-A Ruel wrote: > ...
4 years, 6 months ago (2016-06-14 22:16:05 UTC) #3
M-A Ruel
lgtm
4 years, 6 months ago (2016-06-15 01:25:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066913002/20001
4 years, 6 months ago (2016-06-15 02:30:30 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 03:14:11 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/67813a2b5c1569fca9644e02680c984c90d1ccb0

Powered by Google App Engine
This is Rietveld 408576698