client/cipd.py - Issue 2066913002: swarming-cipd: fix for Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/cipd.py

Issue 2066913002: swarming-cipd: fix for Windows (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master

Patch Set: file_path.remove Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/cipd.py

diff --git a/client/cipd.py b/client/cipd.py

index 6d8eb3e3d5f32643e07cda7b5100c6e5a220da00..b4e6b80377714f15dfc97603d7b43eec06aaef65 100644

--- a/client/cipd.py

+++ b/client/cipd.py

@@ -395,7 +395,7 @@ def get_client(

# binary.

binary_path = unicode(os.path.join(cache_dir, 'cipd' + EXECUTABLE_SUFFIX))

if fs.isfile(binary_path):

- fs.unlink(binary_path)

+ file_path.remove(binary_path)

instance_cache.hardlink(instance_id, binary_path, 0511) # -r-x--x--x

yield CipdClient(binary_path)

« no previous file with comments | « no previous file | client/utils/file_path.py » ('j') | no next file with comments »