Revert of Implement script-side of callback reactions for Custom Elements V1

third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/custom/CustomElementDefinition.h"
 
-#include "core/dom/Attr.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/custom/CEReactionsScope.h"
 #include "core/dom/custom/CustomElement.h"
 #include "core/dom/custom/CustomElementAttributeChangedCallbackReaction.h"
 #include "core/dom/custom/CustomElementConnectedCallbackReaction.h"
 #include "core/dom/custom/CustomElementDisconnectedCallbackReaction.h"
 #include "core/dom/custom/CustomElementUpgradeReaction.h"
 #include "core/html/HTMLElement.h"
 
 namespace blink {
 
 CustomElementDefinition::CustomElementDefinition(
     const CustomElementDescriptor& descriptor)
     : m_descriptor(descriptor)
 {
 }
 
-CustomElementDefinition::CustomElementDefinition(
-    const CustomElementDescriptor& descriptor,
-    const HashSet<AtomicString>& observedAttributes)
-    : m_observedAttributes(observedAttributes)
-    , m_descriptor(descriptor)
-{
-}
-
 CustomElementDefinition::~CustomElementDefinition()
 {
 }
 
 DEFINE_TRACE(CustomElementDefinition)
 {
     visitor->trace(m_constructionStack);
 }
 
 static String errorMessageForConstructorResult(Element* element,
@@ skipping 52 matching lines @@
     element->setCustomElementState(CustomElementState::Undefined);
     // 6.2.2. Enqueue a custom element upgrade reaction given result and
     // definition.
     enqueueUpgradeReaction(element);
     return element;
 }
 
 // https://html.spec.whatwg.org/multipage/scripting.html#concept-upgrade-an-element
 void CustomElementDefinition::upgrade(Element* element)
 {
-    if (!m_observedAttributes.isEmpty())
-        enqueueAttributeChangedCallbackForAllAttributes(element);
+    // TODO(kojii): This should be reversed by exposing observedAttributes from
+    // ScriptCustomElementDefinition, because Element::attributes() requires
+    // attribute synchronizations, and generally elements have more attributes
+    // than custom elements observe.
+    for (const auto& attribute : element->attributes()) {
+        if (hasAttributeChangedCallback(attribute.name()))
+            enqueueAttributeChangedCallback(element, attribute.name(), nullAtom, attribute.value());
+    }
 
     if (element->inShadowIncludingDocument() && hasConnectedCallback())
         enqueueConnectedCallback(element);
 
     m_constructionStack.append(element);
     size_t depth = m_constructionStack.size();
 
     bool succeeded = runConstructor(element);
 
     // Pop the construction stack.
     if (m_constructionStack.last().get())
         DCHECK_EQ(m_constructionStack.last(), element);
     DCHECK_EQ(m_constructionStack.size(), depth); // It's a *stack*.
     m_constructionStack.removeLast();
 
     if (!succeeded)
         return;
 
     CHECK(element->getCustomElementState() == CustomElementState::Custom);
 }
 
-bool CustomElementDefinition::hasAttributeChangedCallback(
-    const QualifiedName& name)
-{
-    return m_observedAttributes.contains(name.localName());
-}
-
 static void enqueueReaction(Element* element, CustomElementReaction* reaction)
 {
     // CEReactionsScope must be created by [CEReactions] in IDL,
     // or callers must setup explicitly if it does not go through bindings.
     DCHECK(CEReactionsScope::current());
     CEReactionsScope::current()->enqueue(element, reaction);
 }
 
 void CustomElementDefinition::enqueueUpgradeReaction(Element* element)
 {
@@ skipping 10 matching lines @@
     enqueueReaction(element, new CustomElementDisconnectedCallbackReaction(this));
 }
 
 void CustomElementDefinition::enqueueAttributeChangedCallback(Element* element,
     const QualifiedName& name,
     const AtomicString& oldValue, const AtomicString& newValue)
 {
     enqueueReaction(element, new CustomElementAttributeChangedCallbackReaction(this, name, oldValue, newValue));
 }
 
-void CustomElementDefinition::enqueueAttributeChangedCallbackForAllAttributes(
-    Element* element)
-{
-    // Avoid synchronizing all attributes unless it is needed, while enqueing
-    // callbacks "in order" as defined in the spec.
-    // https://html.spec.whatwg.org/multipage/scripting.html#concept-upgrade-an-element
-    for (const AtomicString& name : m_observedAttributes)
-        element->synchronizeAttribute(name);
-    for (const auto& attribute : element->attributesWithoutUpdate()) {
-        if (hasAttributeChangedCallback(attribute.name())) {
-            enqueueAttributeChangedCallback(element, attribute.name(),
-                nullAtom, attribute.value());
-        }
-    }
-}
-
 } // namespace blink