If we fail to create a window surface with sRGB, try again without.

If we fail to create a window surface with sRGB, try again without.

Fixes crash when switching to sRGB mode on Nexus 9, among others.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066743003

Committed: https://skia.googlesource.com/skia/+/d76fcda961caa7d71dad45730c5f8e122d8be93f

[Brian Osman, 2016-06-14 13:57:41]

Description was changed from

==========
If we fail to create a window surface with sRGB, try again without.

Fixes crash when switching to sRGB mode on Nexus 9, among others.

BUG=skia:
==========

to

==========
If we fail to create a window surface with sRGB, try again without.

Fixes crash when switching to sRGB mode on Nexus 9, among others.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066743003
==========

[Brian Osman, 2016-06-14 13:58:51]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 13:58:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066743003/1

[Brian Osman, 2016-06-14 13:59:17]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, djsollen@google.com, liyuqian@google.com

[commit-bot: I haz the power, 2016-06-14 14:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 14:12:46]

Dry run: This issue passed the CQ dry run.

[djsollen, 2016-06-14 14:22:01]

do we have any way to report that the creation of an sRGB surface failed?

[Brian Osman, 2016-06-14 15:02:44]

On 2016/06/14 14:22:01, djsollen wrote:
> do we have any way to report that the creation of an sRGB surface failed?

Not in the current framework. The simplest thing I can imagine is modifying
the DisplayParams that are passed in, to reflect what actually happened.

That would at least cause the viewer to not update the title if you tried
to pick sRGB and it wasn't supported.

[bsalomon, 2016-06-14 15:04:53]

lgtm

[Brian Osman, 2016-06-14 15:22:46]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-06-14 15:22:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066743003/1

[commit-bot: I haz the power, 2016-06-14 15:23:52]

Description was changed from

==========
If we fail to create a window surface with sRGB, try again without.

Fixes crash when switching to sRGB mode on Nexus 9, among others.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066743003
==========

to

==========
If we fail to create a window surface with sRGB, try again without.

Fixes crash when switching to sRGB mode on Nexus 9, among others.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066743003

Committed:
https://skia.googlesource.com/skia/+/d76fcda961caa7d71dad45730c5f8e122d8be93f
==========

[commit-bot: I haz the power, 2016-06-14 15:23:53]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d76fcda961caa7d71dad45730c5f8e122d8be93f