Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2066703003: Use float and double for test cases in test-run-wasm-asmjs.cc (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use float and double for test cases in test-run-wasm-asmjs.cc The last 4 test cases in test/cctest/wasm/test-run-wasm-asmjs.cc added by the CL 36911 (https://codereview.chromium.org/2061583002) use float_t and double_t type for WasmRunner. For examples: At line 249: WasmRunner<float_t> r(&module, MachineType::Uint32()); But float_t and double_t depends on FLT_EVAL_METHOD macro of compiler. FLT_EVAL_METHOD is variant on different platform, if the FLT_EVAL_METHOD is 2, both float_t and double_t will be long double and gcc or clang will met error when compiling WasmRunner<long double> r(&module,MachineType::Uint32()); For more details, please refer: float_t: http://www.cplusplus.com/reference/cmath/float_t/ FLT_EVAL_METHOD: https://en.wikipedia.org/wiki/C99 check the IEEE 754 floating point support section directly. This CL used float and double to replace float_t and double_t to avoid this issue. BUG= Committed: https://crrev.com/60df7abc28c4b5e388dde80fe1d77beeaba80af1 Cr-Commit-Position: refs/heads/master@{#36982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M test/cctest/wasm/test-run-wasm-asmjs.cc View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-14 05:47:42 UTC) #2
Mircea Trofin
lgtm
4 years, 6 months ago (2016-06-14 05:48:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066703003/1
4 years, 6 months ago (2016-06-14 06:09:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17135)
4 years, 6 months ago (2016-06-14 06:12:38 UTC) #7
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-14 06:15:38 UTC) #9
titzer
lgtm
4 years, 6 months ago (2016-06-14 16:24:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066703003/1
4 years, 6 months ago (2016-06-15 01:36:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 01:39:05 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 01:39:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60df7abc28c4b5e388dde80fe1d77beeaba80af1
Cr-Commit-Position: refs/heads/master@{#36982}

Powered by Google App Engine
This is Rietveld 408576698