[ia32] Propagate rmodes when computing MemoryOperands

RelocInfo modes were not propagated when computing
MemoryOperands, on IA32. This needed to be fixed so that we can
compile wasm code before creating instances, since the compiled code
needs to be patched up for memory and globals references.

This surfaces in asm-to-wasm scenarios.

Added testing (rather, enhanced existing tests).
Note patch#1 where we fail on ia32, and patch#2 with the fix.

BUG=v8:5072
Committed: https://crrev.com/8c1ba59aeeddba6e4d1684b0666315601d8326f3
Cr-Commit-Position: refs/heads/master@{#36911}

[Mircea Trofin, 2016-06-12 05:27:04]

Patchset #1 (id:1) has been deleted

[Mircea Trofin, 2016-06-12 05:27:11]

Patchset #1 (id:20001) has been deleted

[Mircea Trofin, 2016-06-12 05:47:58]

Description was changed from

==========
Propagate rmodes when computing MemoryOperands

BUG=
==========

to

==========
RelocInfo modes were not propagated when computing 
MemoryOperands, on IA32. This needed to be fixed so that we can 
compile wasm code before creating instances, since the compiled code
needs to be patched up for memory and globals references.

This surfaces in asm-to-wasm scenarios. 

Added testing (enhanced existent tests). Note patch#1 where we fail
on ia32, and patch#2 with the fix.

BUG=v8:5072
==========

[Mircea Trofin, 2016-06-12 05:47:58]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Mircea Trofin, 2016-06-12 05:48:23]

Description was changed from

==========
RelocInfo modes were not propagated when computing 
MemoryOperands, on IA32. This needed to be fixed so that we can 
compile wasm code before creating instances, since the compiled code
needs to be patched up for memory and globals references.

This surfaces in asm-to-wasm scenarios. 

Added testing (enhanced existent tests). Note patch#1 where we fail
on ia32, and patch#2 with the fix.

BUG=v8:5072
==========

to

==========
RelocInfo modes were not propagated when computing 
MemoryOperands, on IA32. This needed to be fixed so that we can 
compile wasm code before creating instances, since the compiled code
needs to be patched up for memory and globals references.

This surfaces in asm-to-wasm scenarios. 

Added testing (rather, enhanced existing tests). 
Note patch#1 where we fail on ia32, and patch#2 with the fix.

BUG=v8:5072
==========

[bradnelson, 2016-06-12 20:50:14]

lgtm

https://codereview.chromium.org/2061583002/diff/60001/test/cctest/wasm/test-r...
File test/cctest/wasm/test-run-wasm-asmjs.cc (right):

https://codereview.chromium.org/2061583002/diff/60001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm-asmjs.cc:141: IF_COMPILED(
Worth making these separate from the oob test? This is kind of mixing concerns.

[Mircea Trofin, 2016-06-13 03:32:55]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2016-06-13 03:32:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2061583002/#ps80001
(title: "sep tests")

[commit-bot: I haz the power, 2016-06-13 03:33:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061583002/80001

[Mircea Trofin, 2016-06-13 03:33:10]

https://codereview.chromium.org/2061583002/diff/60001/test/cctest/wasm/test-r...
File test/cctest/wasm/test-run-wasm-asmjs.cc (right):

https://codereview.chromium.org/2061583002/diff/60001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm-asmjs.cc:141: IF_COMPILED(
On 2016/06/12 20:50:14, bradnelson wrote:
> Worth making these separate from the oob test? This is kind of mixing
concerns.

Good point, thanks. Added a battery of tests for the asm-wasm reloc stuff.

[commit-bot: I haz the power, 2016-06-13 04:21:07]

Description was changed from

==========
RelocInfo modes were not propagated when computing 
MemoryOperands, on IA32. This needed to be fixed so that we can 
compile wasm code before creating instances, since the compiled code
needs to be patched up for memory and globals references.

This surfaces in asm-to-wasm scenarios. 

Added testing (rather, enhanced existing tests). 
Note patch#1 where we fail on ia32, and patch#2 with the fix.

BUG=v8:5072
==========

to

==========
RelocInfo modes were not propagated when computing 
MemoryOperands, on IA32. This needed to be fixed so that we can 
compile wasm code before creating instances, since the compiled code
needs to be patched up for memory and globals references.

This surfaces in asm-to-wasm scenarios. 

Added testing (rather, enhanced existing tests). 
Note patch#1 where we fail on ia32, and patch#2 with the fix.

BUG=v8:5072
==========

[commit-bot: I haz the power, 2016-06-13 04:21:07]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-06-13 04:21:25]

Description was changed from

==========
RelocInfo modes were not propagated when computing 
MemoryOperands, on IA32. This needed to be fixed so that we can 
compile wasm code before creating instances, since the compiled code
needs to be patched up for memory and globals references.

This surfaces in asm-to-wasm scenarios. 

Added testing (rather, enhanced existing tests). 
Note patch#1 where we fail on ia32, and patch#2 with the fix.

BUG=v8:5072
==========

to

==========
RelocInfo modes were not propagated when computing
MemoryOperands, on IA32. This needed to be fixed so that we can
compile wasm code before creating instances, since the compiled code
needs to be patched up for memory and globals references.

This surfaces in asm-to-wasm scenarios.

Added testing (rather, enhanced existing tests).
Note patch#1 where we fail on ia32, and patch#2 with the fix.

BUG=v8:5072

Committed: https://crrev.com/8c1ba59aeeddba6e4d1684b0666315601d8326f3
Cr-Commit-Position: refs/heads/master@{#36911}
==========

[commit-bot: I haz the power, 2016-06-13 04:21:26]

Patchset 3 (id:??) landed as
https://crrev.com/8c1ba59aeeddba6e4d1684b0666315601d8326f3
Cr-Commit-Position: refs/heads/master@{#36911}