tools/mb/mb_config.pyl - Issue 2066483002: gn: Make target_cpu=x86 v8_target_arch=arm builds generate build files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb_config.pyl

Issue 2066483002: gn: Make target_cpu=x86 v8_target_arch=arm builds generate build files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: also make it work Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/mb/mb_config.pyl

diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl

index 09182ba302988a046c522d7c57041d2e8f2b0b85..b88cf4e2ea1e3b56c18944c8c539b53959e1ad5b 100644

--- a/tools/mb/mb_config.pyl

+++ b/tools/mb/mb_config.pyl

@@ -2115,7 +2115,7 @@

'gyp': {'type': 'gyp'},

'hybrid': {

- 'gn_args': 'v8_target_cpu="arm" target_cpu="x86"',

+ 'gn_args': 'v8_target_arch="arm" target_cpu="x86"',

'gyp_defines': 'v8_target_arch=arm target_arch=ia32 host_arch=x86_64',

'mixins': ['disable_nacl'],

« build/config/arm.gni ('K') | « build/config/arm.gni ('k') | no next file » | no next file with comments »