Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: build/config/arm.gni

Issue 2066483002: gn: Make target_cpu=x86 v8_target_arch=arm builds generate build files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: also make it work Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/arm.gni
diff --git a/build/config/arm.gni b/build/config/arm.gni
index d16c0d2a3b798168a2931286583aa333e3dea8b4..ae22c2ca97a3b0ad773e8018623cd6185d892899 100644
--- a/build/config/arm.gni
+++ b/build/config/arm.gni
@@ -90,4 +90,19 @@ if (target_cpu == "arm" || current_cpu == "arm") {
# arm64 supports only "hard".
arm_float_abi = "hard"
arm_use_neon = true
+} else if (target_cpu == "x86") {
+ # We support a build configuration for fuzzing where we build for 32-bit x86,
+ # but tell v8 to generate 32-bit arm code. In this setup, some of the
+ # arm_ variables need to be set even though target_cpu is x86.
+ # (v8_target_arch is set to "arm" in that case, but that's defined in v8,
+ # and build/ can't depend on v8, so don't check for that.)
+ # The values for these variables should be the default values from the
+ # target_cpu == "arm" block above.
+ arm_version = 7
+ arm_fpu = "neon"
+ if (current_os == "android" || target_os == "android") {
+ arm_float_abi = "softfp"
+ } else {
+ arm_float_abi = "hard"
+ }
}
jochen (gone - plz use gerrit) 2016/06/13 15:18:40 why not just replace the if (current_cpu == "arm"
Nico 2016/06/13 15:23:53 I'm guessing that the arm check is there so that t
« no previous file with comments | « no previous file | tools/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698