Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2066323002: Remove SK_SUPPORT_LEGACY_TYPEFACE_PTR (Closed)

Created:
4 years, 6 months ago by f(malita)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, apavlov+blink_chromium.org, Stephen Chennney, rwlbuis, extensions-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-css, Justin Novosad, dglazkov+blink, Rik, blink-reviews, chromium-apps-reviews_chromium.org, ajuma+watch_chromium.org, derat+watch_chromium.org, jbroman, krit, darktears, cc-bugs_chromium.org, f(malita), danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SK_SUPPORT_LEGACY_TYPEFACE_PTR Convert clients to the sk_sp-based SkTypeface API R=reed@google.com,bungeman@chromium.org BUG=skia:5077 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6d979c279cbc55ed0f3fbb0b158ef09559db9dd2 Cr-Commit-Position: refs/heads/master@{#400675}

Patch Set 1 #

Patch Set 2 : minor cleanup #

Patch Set 3 : Mac, Android fixes #

Patch Set 4 : Win fix #

Patch Set 5 : moar Mac fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M cc/layers/heads_up_display_layer.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/extensions/icon_with_badge_image_source.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_cast_android.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSourceTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/WebFontDecoder.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/harfbuzz_font_skia.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/harfbuzz_font_skia.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/platform_font_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/render_text_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
f(malita)
4 years, 6 months ago (2016-06-16 09:38:28 UTC) #2
bungeman-chromium
lgtm
4 years, 6 months ago (2016-06-16 14:55:48 UTC) #3
bungeman-skia
lgtm
4 years, 6 months ago (2016-06-16 14:56:32 UTC) #5
f(malita)
+owners danakj: cc/layers/ finnur: chrome/browser/ui/extensions/ chcunningham: media/blink msw: ui/gfx PTAL - thanks!
4 years, 6 months ago (2016-06-17 07:42:49 UTC) #8
msw
ui/gfx lgtm
4 years, 6 months ago (2016-06-17 17:29:37 UTC) #9
danakj
On 2016/06/17 07:42:49, f(malita) wrote: > +owners > > danakj: cc/layers/ LGTM > finnur: chrome/browser/ui/extensions/ ...
4 years, 6 months ago (2016-06-17 17:33:43 UTC) #10
chcunningham
media LGTM
4 years, 6 months ago (2016-06-17 17:45:38 UTC) #11
Finnur
Extension OWNERS LGTM
4 years, 6 months ago (2016-06-20 10:13:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066323002/80001
4 years, 6 months ago (2016-06-20 10:59:53 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-20 14:19:41 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 14:21:15 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6d979c279cbc55ed0f3fbb0b158ef09559db9dd2
Cr-Commit-Position: refs/heads/master@{#400675}

Powered by Google App Engine
This is Rietveld 408576698