ui/gfx/render_text_mac.mm - Issue 2066323002: Remove SK_SUPPORT_LEGACY_TYPEFACE_PTR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_mac.mm

Issue 2066323002: Remove SK_SUPPORT_LEGACY_TYPEFACE_PTR (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moar Mac fixes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_mac.mm

diff --git a/ui/gfx/render_text_mac.mm b/ui/gfx/render_text_mac.mm

index a6e28c25cd8c67a2f304a31c3848d267dd68723a..bd62b5d4aa07586f45cf61026dd8c5460164b25a 100644

--- a/ui/gfx/render_text_mac.mm

+++ b/ui/gfx/render_text_mac.mm

@@ -221,7 +221,7 @@ void RenderTextMac::DrawVisualText(internal::SkiaTextRenderer* renderer) {

// The painter adds its own ref. So don't |release()| it from the ref ptr in

// TextRun.

- renderer->SetTypeface(run.typeface.get());

+ renderer->SetTypeface(run.typeface);

renderer->DrawPosText(&run.glyph_positions[0], &run.glyphs[0],

run.glyphs.size());

« no previous file with comments | « ui/gfx/render_text_harfbuzz.cc ('k') | no next file » | no next file with comments »