Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2065953002: [turbofan] Introduce dedicated NumberConvertHoleNaN simplified operator. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce dedicated NumberConvertHoleNaN simplified operator. This is part of the fixes required to make type feedback viable for TurboFan on Octane. R=jarin@chromium.org Committed: https://crrev.com/2fdf33bb2aa62a11853f2c51dccfd2c94aeebffa Cr-Commit-Position: refs/heads/master@{#36966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -22 lines) Patch
M src/compiler/js-native-context-specialization.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-14 12:51:30 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-06-14 12:56:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065953002/1
4 years, 6 months ago (2016-06-14 13:07:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 13:22:06 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 13:24:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fdf33bb2aa62a11853f2c51dccfd2c94aeebffa
Cr-Commit-Position: refs/heads/master@{#36966}

Powered by Google App Engine
This is Rietveld 408576698