Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2063073004: [turbofan] Lower to NumberAdd / NumberSubtract if type feedback is Number. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_UnboxHoleyDouble
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower to NumberAdd / NumberSubtract if type feedback is Number. If JSAdd or JSSubtract has number feedback, there's no benefit to use the speculative versions of NumberAdd and/or NumberSubtract. Relying on the existing operators gives us some nice truncations instead, so let's stick to that for now. R=jarin@chromium.org Committed: https://crrev.com/53d92c1c6b8595632da0887e845d03882cd1ee75 Cr-Commit-Position: refs/heads/master@{#36987}

Patch Set 1 #

Patch Set 2 : REBASE and fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 2 chunks +17 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (11 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-14 13:16:11 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-06-14 13:17:18 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 2065953002 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-14 13:17:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063073004/1
4 years, 6 months ago (2016-06-14 13:24:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/3236) v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-14 13:42:14 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063073004/20001
4 years, 6 months ago (2016-06-15 05:19:23 UTC) #11
commit-bot: I haz the power
This CL has an open dependency (Issue 2064953004 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-15 05:43:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063073004/20001
4 years, 6 months ago (2016-06-15 06:47:42 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 06:50:05 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 06:53:03 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53d92c1c6b8595632da0887e845d03882cd1ee75
Cr-Commit-Position: refs/heads/master@{#36987}

Powered by Google App Engine
This is Rietveld 408576698