Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2065933004: Support for accessing arrays in the debugger (Closed)

Created:
4 years, 6 months ago by sigurdm
Modified:
4 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
dartino-code-reviews_googlegroups.com
Base URL:
git@github.com:dartino/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -58 lines) Patch
M pkg/dartino_compiler/lib/debug_state.dart View 2 chunks +13 lines, -0 lines 2 comments Download
M pkg/dartino_compiler/lib/src/dartino_compiler_implementation.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dartino_compiler/lib/vm_commands.dart View 8 chunks +42 lines, -3 lines 0 comments Download
M pkg/dartino_compiler/lib/vm_context.dart View 11 chunks +58 lines, -36 lines 0 comments Download
M src/shared/connection.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/vm/session.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/vm/session.cc View 4 chunks +52 lines, -17 lines 0 comments Download
M tests/debugger/print_local_structure_expected.txt View 1 chunk +25 lines, -0 lines 2 comments Download
M tests/debugger/print_local_structure_test.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sigurdm
4 years, 6 months ago (2016-06-15 09:17:33 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/2065933004/diff/1/pkg/dartino_compiler/lib/debug_state.dart File pkg/dartino_compiler/lib/debug_state.dart (right): https://codereview.chromium.org/2065933004/diff/1/pkg/dartino_compiler/lib/debug_state.dart#newcode42 pkg/dartino_compiler/lib/debug_state.dart:42: class RemoteArray extends RemoteObject { We probably need ...
4 years, 6 months ago (2016-06-15 11:25:09 UTC) #3
sigurdm
Committed patchset #1 (id:1) manually as 35b7e52b196c1afe94a89e398cec60904f3f5199 (presubmit successful).
4 years, 6 months ago (2016-06-15 14:50:40 UTC) #5
sigurdm
4 years, 6 months ago (2016-06-15 14:50:49 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2065933004/diff/1/pkg/dartino_compiler/lib/de...
File pkg/dartino_compiler/lib/debug_state.dart (right):

https://codereview.chromium.org/2065933004/diff/1/pkg/dartino_compiler/lib/de...
pkg/dartino_compiler/lib/debug_state.dart:42: class RemoteArray extends
RemoteObject {
On 2016/06/15 11:25:09, Søren Gjesse wrote:
> We probably need a mechanism here for handling large arrays, so that the
content
> can be partial, and more elements can be fetched in batches.
> 
> Please open an issue on this.
I made an issue and a TODO.

https://codereview.chromium.org/2065933004/diff/1/tests/debugger/print_local_...
File tests/debugger/print_local_structure_expected.txt (right):

https://codereview.chromium.org/2065933004/diff/1/tests/debugger/print_local_...
tests/debugger/print_local_structure_expected.txt:51: > p *list._list.1
On 2016/06/15 11:25:09, Søren Gjesse wrote:
> How about the operator [] syntax?

Good idea. I'll handle that in a follow up CL.

Powered by Google App Engine
This is Rietveld 408576698