Support for accessing arrays in the debugger

pkg/dartino_compiler/lib/vm_commands.dart

 // Copyright (c) 2015, the Dartino project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE.md file.
 
 library dartino_compiler.vm_commands;
 
 import 'dart:convert' show
     UTF8;
 
 import 'dart:typed_data' show
@@ skipping 32 matching lines @@
         int floatSize = CommandBuffer.readInt32FromBuffer(buffer, offset);
         offset += 4;
         int vmState = CommandBuffer.readInt32FromBuffer(buffer, offset);
         return new HandShakeResult(
             success, version, wordSize, floatSize, VmState.values[vmState]);
       case VmCommandCode.InstanceStructure:
         int classId =
             translateClass(CommandBuffer.readInt64FromBuffer(buffer, 0));
         int fields = CommandBuffer.readInt32FromBuffer(buffer, 8);
         return new InstanceStructure(classId, fields);
+      case VmCommandCode.ArrayStructure:
+        int length = CommandBuffer.readInt32FromBuffer(buffer, 0);
+        return new ArrayStructure(length);
       case VmCommandCode.Instance:
         int classId = translateClass(
             CommandBuffer.readInt64FromBuffer(buffer, 0));
         return new Instance(classId);
       case VmCommandCode.Class:
         int classId = translateClass(
             CommandBuffer.readInt64FromBuffer(buffer, 0));
         return new ClassValue(classId);
       case VmCommandCode.Integer:
         int value = CommandBuffer.readInt64FromBuffer(buffer, 0);
         return new Integer(value);
       case VmCommandCode.Double:
         return new Double(CommandBuffer.readDoubleFromBuffer(buffer, 0));
       case VmCommandCode.Boolean:
         return new Boolean(CommandBuffer.readBoolFromBuffer(buffer, 0));
       case VmCommandCode.Null:
         return const NullValue();
       case VmCommandCode.String:
         return new StringValue(
             CommandBuffer.readStringFromBuffer(buffer, 0, buffer.length));
+      case VmCommandCode.Array:
+        int length = CommandBuffer.readInt32FromBuffer(buffer, 0);
+        return new Array(length);
       case VmCommandCode.StdoutData:
         return new StdoutData(buffer);
       case VmCommandCode.StderrData:
         return new StderrData(buffer);
       case VmCommandCode.ObjectId:
         int id = CommandBuffer.readInt64FromBuffer(buffer, 0);
         return new ObjectId(id);
       case VmCommandCode.ProcessBacktrace:
         int frames = CommandBuffer.readInt32FromBuffer(buffer, 0);
         ProcessBacktrace backtrace = new ProcessBacktrace(frames);
@@ skipping 74 matching lines @@
         Int32List classTable = readArray(classEntries);
 
         int functionEntries = readInt();
         Int32List functionTable = readArray(functionEntries);
 
         return new ProgramInfoCommand(classTable, functionTable, hash);
       case VmCommandCode.DebuggingReply:
         bool isFromSnapshot = CommandBuffer.readBoolFromBuffer(buffer, 0);
         int snapshotHash = CommandBuffer.readInt32FromBuffer(buffer, 1);
         return new DebuggingReply(isFromSnapshot, snapshotHash);
+      case VmCommandCode.CommandError:
+        int errorCode = CommandBuffer.readInt32FromBuffer(buffer, 0);
+        return new CommandError(ErrorCode.values[errorCode]);
       default:
         throw 'Unhandled command in VmCommand.fromBuffer: $code';
     }
   }
 
   void addTo(Sink<List<int>> sink, int translateObject(
       MapId mapId, int index)) {
     internalAddTo(sink, new CommandBuffer<VmCommandCode>(), translateObject);
   }
 
@@ skipping 1016 matching lines @@
         ..addUint32(fieldAccesses.length);
     for (int fieldAccess in fieldAccesses) {
       buffer.addUint32(fieldAccess);
     }
     buffer.sendOn(sink, code);
   }
 
   /// Peer will respond with a [DartValue].
   int get numberOfResponsesExpected => 1;
 
-  String valuesToString() => "frame: $frame, slot: $slot";
+  String valuesToString() =>
+      "frame: $frame, slot: $slot, fieldAccesses: $fieldAccesses";
 }
 
 class ProcessInstanceStructure extends VmCommand {
   final int frame;
   final int slot;
   final List<int> fieldAccesses;
 
   const ProcessInstanceStructure(this.frame, this.slot, this.fieldAccesses)
       : super(VmCommandCode.ProcessInstanceStructure);
 
@@ skipping 10 matching lines @@
     }
     buffer.sendOn(sink, code);
   }
 
   /// Peer will respond with a [DartValue] or [InstanceStructure] and a number
   /// of [DartValue]s.
   ///
   /// The number of responses is not fixed.
   int get numberOfResponsesExpected => null;
 
-  String valuesToString() => "frame: $frame, slot: $slot";
+  String valuesToString() =>
+      "frame: $frame, slot: $slot fieldAccesses: $fieldAccesses";
 }
 
 class ProcessRestartFrame extends VmCommand {
   final int frame;
 
   const ProcessRestartFrame(this.frame)
       : super(VmCommandCode.ProcessRestartFrame);
 
   void internalAddTo(
       Sink<List<int>> sink,
@@ skipping 319 matching lines @@
       CommandBuffer<VmCommandCode> buffer,
       int translateObject(MapId mapId, int index)) {
     throw new UnimplementedError();
   }
 
   int get numberOfResponsesExpected => 0;
 
   String valuesToString() => "classId: $classId, fields: $fields";
 }
 
+class ArrayStructure extends VmCommand {
+  final int length;
+  const ArrayStructure(this.length)
+      : super(VmCommandCode.ArrayStructure);
+
+  void internalAddTo(
+      Sink<List<int>> sink,
+      CommandBuffer<VmCommandCode> buffer,
+      int translateObject(MapId mapId, int index)) {
+    throw new UnimplementedError();
+  }
+
+  int get numberOfResponsesExpected => 0;
+
+  String valuesToString() => "length: $length";
+}
+
 abstract class DartValue extends VmCommand {
   const DartValue(VmCommandCode code)
       : super(code);
 
   void internalAddTo(
       Sink<List<int>> sink,
       CommandBuffer<VmCommandCode> buffer,
       int translateObject(MapId mapId, int index)) {
     throw new UnimplementedError();
   }
@@ skipping 74 matching lines @@
 
 class StringValue extends DartValue {
   final String value;
 
   const StringValue(this.value)
       : super(VmCommandCode.String);
 
   String dartToString() => "'$value'";
 }
 
+class Array extends DartValue {
+  final int length;
+
+  const Array(this.length)
+      : super(VmCommandCode.Array);
+
+  String dartToString() => "array of length $length";
+}
+
 class CommandError extends VmCommand {
   final ErrorCode errorCode;
 
   const CommandError(this.errorCode)
       : super(VmCommandCode.CommandError);
 
   int get numberOfResponsesExpected => 0;
 
   String valuesToString() => "command error: $errorCode";
 }
@@ skipping 115 matching lines @@
   MapLookup,
   ObjectId,
 
   Integer,
   Boolean,
   Null,
   Double,
   String,
   Instance,
   Class,
-  InstanceStructure
+  Array,
+  InstanceStructure,
+  ArrayStructure,
 }
 
 enum MapId {
   methods,
   classes,
   constants,
   fibers,
 }