Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2065933003: [Findit] Adding variable builder to cover 'Blimp Linux (dbg)' on main waterfall (Closed)

Created:
4 years, 6 months ago by lijeffrey
Modified:
4 years, 6 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+build_chromium.org, stgao, chanli
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Findit] Adding variable builder to cover 'Blimp Linux (dbg)' on main waterfall BUG=620094 Committed: https://chromium.googlesource.com/chromium/tools/build/+/683075656e5c4eca59f224ff65e0dd36e10c918b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M masters/master.tryserver.chromium.linux/master.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium.linux/slaves.cfg View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
lijeffrey
Hi Sergey, This change adds another variable builder to correspond to 'Blimp Linux (dbg)' on ...
4 years, 6 months ago (2016-06-14 23:47:36 UTC) #3
Sergey Berezin
LGTM + comment - check the graphs go/prhnj and see which pool makes more sense. ...
4 years, 6 months ago (2016-06-15 19:29:57 UTC) #4
lijeffrey
https://codereview.chromium.org/2065933003/diff/1/masters/master.tryserver.chromium.linux/slaves.cfg File masters/master.tryserver.chromium.linux/slaves.cfg (right): https://codereview.chromium.org/2065933003/diff/1/masters/master.tryserver.chromium.linux/slaves.cfg#newcode75 masters/master.tryserver.chromium.linux/slaves.cfg:75: 'linux_chromium_blimp_variable', # linux_blimp On 2016/06/15 19:29:57, Sergey Berezin wrote: ...
4 years, 6 months ago (2016-06-15 21:35:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065933003/1
4 years, 6 months ago (2016-06-15 21:35:49 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 21:38:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/683075656e5c4eca59f2...

Powered by Google App Engine
This is Rietveld 408576698