Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2065843002: [Android] Only pass --adb-path to adb_install_apk for M51 and above. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@update-version
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Only pass --adb-path to adb_install_apk for M51 and above. BUG=618473 Committed: https://chromium.googlesource.com/chromium/tools/build/+/bd4d31d9ad63c53115cefefd8b4a10027ac4ff86

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1510 lines, -1 line) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/downgrade_install_tester_basic.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/specific_install_tester_basic.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_aosp_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_aosp_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_aosp_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_fyi_perf_bisect.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5X_perf_bisect.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5_perf_bisect.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus6_perf_bisect.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus9_perf_bisect.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_bisect.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_cq.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_aosp_perf_bisect.json View 2 chunks +28 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5X_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus6_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus7_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus9_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_one_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_cq.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_webview_aosp_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_fyi_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5X_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus6_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus7_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus9_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_one_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_cq.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_webview_aosp_perf_bisect.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_aosp_perf_bisect.json View 2 chunks +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_WebView_CTS_L_MR1__dbg_.json View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbudorick
4 years, 6 months ago (2016-06-13 23:13:18 UTC) #2
martiniss
lgtm https://codereview.chromium.org/2065843002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2065843002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode506 scripts/slave/recipe_modules/chromium_android/api.py:506: if int(self.m.chromium.get_version().get('MAJOR', 0)) > 50: this should be ...
4 years, 6 months ago (2016-06-13 23:17:30 UTC) #3
jbudorick
https://codereview.chromium.org/2065843002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2065843002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode506 scripts/slave/recipe_modules/chromium_android/api.py:506: if int(self.m.chromium.get_version().get('MAJOR', 0)) > 50: On 2016/06/13 23:17:30, martiniss ...
4 years, 6 months ago (2016-06-14 19:03:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065843002/20001
4 years, 6 months ago (2016-06-14 19:03:40 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 19:08:18 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/bd4d31d9ad63c53115ce...

Powered by Google App Engine
This is Rietveld 408576698