scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_aosp_perf_bisect.json - Issue 2065843002: [Android] Only pass --adb-path to adb_install_apk for M51 and above.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_aosp_perf_bisect.json

Issue 2065843002: [Android] Only pass --adb-path to adb_install_apk for M51 and above. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@update-version

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_cq.json ('k') | scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_aosp_perf_bisect.json

diff --git a/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_aosp_perf_bisect.json b/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_aosp_perf_bisect.json

index 8a113bf6929fa6eaa40ad7335181cf3f41325ad4..3febd3b4ab5e04fdd2691d00f987b6d07d9a5df9 100644

--- a/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_aosp_perf_bisect.json

+++ b/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_aosp_perf_bisect.json

@@ -438,6 +438,20 @@

{

"cmd": [

+ "python",

+ "-u",

+ "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

+ "[SLAVE_BUILD]/src/chrome/VERSION",

+ "/path/to/tmp/"

+ ],

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

+ "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"

+ },

+ "name": "get version"

+ },

+ {

+ "cmd": [

"[SLAVE_BUILD]/src/build/android/adb_install_apk.py",

"SystemWebView.apk",

"-v",

@@ -455,6 +469,20 @@

{

"cmd": [

+ "python",

+ "-u",

+ "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

+ "[SLAVE_BUILD]/src/chrome/VERSION",

+ "/path/to/tmp/"

+ ],

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

+ "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"

+ },

+ "name": "get version (2)"

+ },

+ {

+ "cmd": [

"[SLAVE_BUILD]/src/build/android/adb_install_apk.py",

"SystemWebViewShell.apk",

"-v",