chrome/test/chromedriver/server/http_handler.cc - Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/server/http_handler.cc

Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed hard coded network values to constants. Fixed style issues. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/client/chromedriver.py ('K') | « chrome/test/chromedriver/client/command_executor.py ('k') | chrome/test/chromedriver/session_commands.h » ('j') | chrome/test/chromedriver/session_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/server/http_handler.cc

diff --git a/chrome/test/chromedriver/server/http_handler.cc b/chrome/test/chromedriver/server/http_handler.cc

index 189bdb53ca6832b1feef717525b01be9c06c8488..6c0e810823ffaf31109a160613764011ab07ef42 100644

--- a/chrome/test/chromedriver/server/http_handler.cc

+++ b/chrome/test/chromedriver/server/http_handler.cc

@@ -382,6 +382,11 @@ HttpHandler::HttpHandler(

"session/:sessionId/location",

WrapToCommand("SetGeolocation", base::Bind(&ExecuteSetLocation))),

CommandMapping(

+ kPost,

+ "session/:sessionId/network_connection",

+ WrapToCommand("SetNetworkConnection",

+ base::Bind(&ExecuteSetNetworkConnection))),

+ CommandMapping(

kGet,

"session/:sessionId/chromium/network_conditions",

WrapToCommand("GetNetworkConditions",